1823252 - Inconsistent button style in the quick filter toolbar - spacing between checked indicator, icons and/or button text label sometimes too much, or too little.

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Sören Hentzschel]

Attachment: screenshot

The button style in the quick filter bar is inconsistent.

• The buttons in the "primary bar" have different spacings on the left and on the right side of the icons. It was probably already the case in Thunderbird 102 but with the new design that always show a background and this bar on the left side of every button it's now very noticeable and doesn't look right.
• The text buttons below the filter field don't have enough padding on the sides.
• There is some spacing between the left bar and the text for the subject button but it's too much compared to the primary buttons and for all other text buttons the spacing is completely missing.

Tested in Thunderbird Daily 113.0a1 (2023-03-19) on macOS 13.2.1.

Comment 1

[Thomas D. (:thomas8)]

Attachment: Screenshot: en-US also suffering from inconsistent button layout

Thanks Sören, I agree. Especially the text filter sub-filter buttons (Sender, Recipients, Subject, Body) are extremely inconsistent and look very amateurish. It's not important to have same/similar/minimum button width - but the variation in the distance between indicator and text looks really bad and makes it harder to understand which indicator belongs to which button label.

Richard?

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug 1823252 - Increase the inline padding on check-button. r=micahilbery

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f101aed90e85
Increase the inline padding on check-button. r=micahilbery

Comment 4

[Sören Hentzschel]

Only partially fixed. Please see also the feedback in comment #1, there are still different dinstances between the indiciator and the text.

Comment 5

[Richard Marti (:Paenglab)]

This is because this buttons have the same width.

Comment 6

[Sören Hentzschel]

This is because this buttons have the same width.

I guess you mean the same min-width because they all have a different width (69.2px, 75.8px, 66px, 110.3px for German). And yes, that's exactly what should be fixed. It makes no sense to give these buttons "the same width" if they all have a different text length. The solution is simple: just remove the min-width. I tried it and it looked much better. And if you feel that more spacing around the text is needed you could increase the padding a bit. But giving a fixed min-width for buttons with different text lengths will always produce inconsistencies. Please also don't forget that there are other languages as English, like German, where you have to assume that the text lengths sometimes differ significantly.

Please see also the comment from :thomas8:

Especially the text filter sub-filter buttons (Sender, Recipients, Subject, Body) are extremely inconsistent and look very amateurish. It's not important to have same/similar/minimum button width - but the variation in the distance between indicator and text looks really bad and makes it harder to understand which indicator belongs to which button label.

Comment 7

[Richard Marti (:Paenglab)]

This is something for a new bug.