1823546 - `Compact folders` is not enabled when account node is selected in the folder pane

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Blueiceking]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36

Steps to reproduce:

This with TB 112.0b1 (32-bit)
Compaction - Before (I believe at TB Beta 110 beta 4) I could perform compaction using steps below, now I can't. What am I doing wrong?
Below are the steps I perform for compaction - I usually only do this about every 90 days.

1. Click on First Email account,
2. Click on top menu - option File, now the Compact Folders is greyed out.
3. The only way I can use Compact is by selecting each folder under each email account and the select File then click Compact Folders, this is true even if I start at the "Inbox" folder for each email account. Where before I would see status of each folder and sub-folder. Now sometimes it never appears to complete, like when compacting Trash Folder - the message at bottom left is "[e-mail]: Compacting folder..."

Actual results:

See "what did you do? (steps to reproduce)"

Expected results:

After perform step 2 - I would be able to compact all folders/and sub-folders and see the status at bottom left showing all activity with amount of storage saved.

Comment 1

[Calum Mackay]

Just to confirm, it's present for me, and working correctly in:

113.0a1 (2023-03-20) (64-bit); MacOS Ventura 13.2.1

Comment 2

[Calum Mackay]

hmm. I may have to back-track on that. I thought it was working correctly, but on double-checking, I find a couple of folders still have deleted messages in them (IMAP mark-as-deleted), after Compact claims to have finished. But that's different to what's reported here, of course.

Comment 3

[Wayne Mery (:wsmwk)]

Right, this bug is about the menu choice not being offered.

Compact folders is offered in 2023-03-20, but not in 023-03-19, so it got fixed ... partially, because it is not offered if the account in folder pane is selected. It is only shown when a folder of the account is selected.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1823546 - Tidy up Compact Folders commands. r=#thunderbird-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/84c10b2b07f9
Tidy up Compact Folders commands. r=mkmelin

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9329190 [details]
Bug 1823546 - Tidy up Compact Folders commands. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 113.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/c489eb380580