Closed Bug 1829632 Opened 1 year ago Closed 1 year ago

`Compact` toolbar button from Unified Toolbar customization doesn't work

Categories

(Thunderbird :: Mail Window Front End, defect, P2)

Thunderbird 114

Tracking

(thunderbird_esr102 unaffected, thunderbird113 fixed)

RESOLVED FIXED
114 Branch
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird113 --- fixed

People

(Reporter: mkmelin, Assigned: mkmelin)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [Supernova3p])

Attachments

(1 file)

Add Compact to the unified toolbar.
Click it, it won't work.
Uncaught TypeError: about3Pane.folderPane.compactFolders is not a function
handleClick chrome://messenger/content/unifiedtoolbar/compact-folder-button.mjs:33
compact-folder-button.mjs:33:27
handleClick chrome://messenger/content/unifiedtoolbar/compact-folder-button.mjs:33

Compacting through the File menu works.

Whiteboard: [Supernova] → [Supernova3p]

Good find! Thanks Magnus.

Severity: -- → S3
Priority: -- → P2
Summary: toolbar button to compact folders doesn't work → `Compact` toolbar button from Unified Toolbar customization doesn't work

This was working relatively recently; unfortunately I don't have a regression window…

working: 114.0a1 (2023-04-18) (64-bit)

not working: 114.0a1 (2023-04-20) (64-bit)

I don't have 0419 to hand; will download and try.

working: 114.0a1 (2023-04-19) (64-bit)

not working: 114.0a1 (2023-04-20) (64-bit)

MacOS Ventura 13.3.1

introduced in 0420.

Regressed by: 1823546
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Target Milestone: --- → 114 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/27d13fbd549f
Make Compact toolbar button from Unified Toolbar customization work after 1823546. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Comment on attachment 9330124 [details]
Bug 1829632 - Make Compact toolbar button from Unified Toolbar customization work after 1823546. r=#thunderbird-reviewers

[Approval Request Comment]
Regression fix for bug 1823546 which now went to beta

Attachment #9330124 - Flags: approval-comm-beta?
Duplicate of this bug: 1830235
Duplicate of this bug: 1830241

Comment on attachment 9330124 [details]
Bug 1829632 - Make Compact toolbar button from Unified Toolbar customization work after 1823546. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9330124 - Flags: approval-comm-beta? → approval-comm-beta+

works for me
macOS 13.3.1 Ventura, en-UK

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: