1823548 - Ignore thread (and subthread) not quite working

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

Ignore (sub)thread should show a notification allowing you to undo.
https://searchfox.org/comm-central/rev/cf453cf8141b76eca5dea975c29d6ed610cb229d/mail/base/content/mailCommon.js#225,229

At least ignore subthread doesn't seem to work quite right wrt the menus either. The checkmark of whether it's in an ignored subthread or not is out of sync with what the current state is.

Comment 1

[Thomas D. (:thomas8)]

(In reply to Magnus Melin [:mkmelin] from comment #0)

Ignore (sub)thread should show a notification allowing you to undo.
At least ignore subthread doesn't seem to work quite right wrt the menus either.

I guess the latter part makes this go beyond a mere sn-msglist issue.

Comment 2

[Geoff Lankow (:darktrojan)]

I'm already looking at these. There's some really horrible code here.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1823548 - Fix problems with ignoring and watching threads. r=aleca

... and other problems with ignoring and watching threads.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1823548 - Ensure notifications from all thread tree views are listened to. r=aleca

When setting up the thread tree view, we added a listener object to it in lieu of a XUL tree. But in some cases the view changed but the listener wasn't added.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1823548 - Fix database notifications about flag changes to threads. r=aleca

The database notifies listeners about thread flag changes, using a mechanism that's supposed to be used for message flag changes.
We should be able to add the message flags to the notifications to get the right result.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bbb7aa8ad7d8
Ensure notifications from all thread tree views are listened to. r=aleca
https://hg.mozilla.org/comm-central/rev/6e6b44e5e295
Fix problems with ignoring and watching threads. r=aleca
https://hg.mozilla.org/comm-central/rev/49b0cf6e492b
Fix database notifications about flag changes to threads. r=aleca