1823577 - `open message in conversation` briefly flashes folder pane

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Wayne Mery (:wsmwk)]

+++ This bug was initially created as a clone of Bug #1820057 +++

open message in conversation now works.

But as it is loading the message list with the conversation, it briefly flashes folder pane

Comment 1

[Alessandro Castellani [:aleca]]

This is probably the restoreState() method's fault running a bit later.
We could probably invert things and start from a collapsed folder pane state by default, and open it if needed.
We'll investigate.

Comment 2

[Magnus Melin [:mkmelin]]

This is a really odd piece of UI... Perhaps ideally it would continue showing the folder pane and highlight folders with hits (and make the folder pane inert?)

Comment 3

[Geoff Lankow (:darktrojan)]

Not as odd as it used to be. :-)

I think the idea of using the folder pane as a way to filter search results has potential, but it's clearly not going to happen for 115.

Right now I'm seeing if I can avoid running folderPane.init altogether in search tabs, as well as hiding it, without breaking a whole bunch of things. So far, so good.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1823577 - Start about:3pane with folder pane hidden, then show it if wanted. r=#thunderbird-reviewers

This adjusts pane-splitter so that it can be used with an element that is already collapsed. Then the folder pane can be collapsed initially.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1823577 - Don't initialise about:3pane's `folderPane` if it won't be used. r=#thunderbird-front-end-reviewers

By setting up the folder pane, we automatically set gFolder to the first item in the tree, even
though it's not the folder being displayed. We can use gFolder being falsy to avoid things like
the Folder Pane menu item being enabled (thus not needing to initialise folderPane), and storing
search tabs in the session store (restoring them doesn't work, so storing them is pointless).

Depends on D178003

Comment 6

[Phabricator Automation]

Comment on attachment 9333570 [details]
Bug 1823577 - Don't initialise about:3pane's folderPane if it won't be used. r=#thunderbird-front-end-reviewers

Revision D178004 was moved to bug 1833275. Setting attachment 9333570 [details] to obsolete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e6a7fe755c84
Start about:3pane with panes hidden, then show them if wanted. r=aleca

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9333569 [details]
Bug 1823577 - Start about:3pane with folder pane hidden, then show it if wanted. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 114.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/07cc5b88b061