Closed Bug 1823608 Opened 1 year ago Closed 1 year ago

Result menu dismiss option does NOT work for top picks and firefox suggest

Categories

(Firefox :: Address Bar, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
113 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox111 --- unaffected
firefox112 --- verified
firefox113 --- verified

People

(Reporter: cbaica, Assigned: dao)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [snt-urlbar-results-menu])

Attachments

(2 files)

Found in

  • Fx 112.0b4

Affected versions

  • Fx 113.0a1
  • Fx 112.0b4

Affected platforms

  • Windows 10
  • macOS
  • Ubuntu 22

Preconditions

  • browser.urlbar.resultMenu set to true
  • browser.urlbar.quicksuggest.blockingEnabled set to true
  • browser.urlbar.merino.endpointURL to https://merinopy.services.mozilla.com/api/v1/suggest
  • browser.urlbar.merino.providers to adm,top_picks
  • browser.urlbar.bestMatch.enabled to true
  • browser.search.region to US
  • browser.urlbar.quicksuggest.dataCollection.enabled to true
  • browser.urlbar.bestMatch.blockingEnabled to true

Steps to reproduce

  1. Launch Firefox.
  2. Type 'dell' in the address bar.
  3. Using the result menu, choose the dismiss option.

Expected result

  • Top pick for dell is dismissed and not shown again.

Actual result

  • The top pick is not dismissed.

Regression range

Additional notes

  • Firefox suggestions dismiss does not work (sponsored or non-sponsored suggestions are not dismissed).
Has STR: --- → yes
Keywords: regression
Whiteboard: [snt-urlbar-results-menu]
Summary: Result menu dismiss option does NOT work for top picks → Result menu dismiss option does NOT work for top picks and firefox suggest

D'oh, thanks for catching this!

Assignee: nobody → dao+bmo
Priority: -- → P1
Regressed by: 1822338

Set release status flags based on info from the regressing bug 1822338

Attachment #9324146 - Attachment description: WIP: Bug 1823608 - Fix and consolidate logic for whether quickSuggest and bestMatch blocking are enabled. → Bug 1823608 - Fix and consolidate logic for whether quickSuggest and bestMatch blocking are enabled.
Blocks: 1823643

When verifying this, please also test with browser.urlbar.quicksuggest.blockingEnabled = false and browser.urlbar.bestMatch.blockingEnabled = false. As of bug 1822338, we want blocking to be enabled when the result menu is enabled, even with those prefs set to false.

Flags: qe-verify+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac52e391141d
Fix and consolidate logic for whether quickSuggest and bestMatch blocking are enabled. r=mak

Comment on attachment 9324146 [details]
Bug 1823608 - Fix and consolidate logic for whether quickSuggest and bestMatch blocking are enabled.

Beta/Release Uplift Approval Request

  • User impact if declined: See comment 0. Note that this would NOT affect regular users on Firefox 112, as prefs for relevant features such as browser.urlbar.quicksuggest.blockingEnabled, browser.urlbar.quicksuggest.blockingEnabled, and browser.urlbar.resultMenu default to false on release. However, a Nimbus experiment is planned for 112 where this would be an issue.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See comment 0 and comment 4.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): As I explained, this issue doesn't affect regular users, and the same would be true for the fix.
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9324146 - Flags: approval-mozilla-beta?
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
QA Whiteboard: [qa-triaged]

Hello,

Confirming this issue as verified fixed on 113.0a1(20230321213816) using macOS 13, Windows 11 and Ubuntu 22.

Verified with browser.urlbar.quicksuggest.blockingEnabled = false and browser.urlbar.bestMatch.blockingEnabled = false as well, per requested in Comment 4.

Comment on attachment 9324146 [details]
Bug 1823608 - Fix and consolidate logic for whether quickSuggest and bestMatch blocking are enabled.

Approved for 112.0b6

Attachment #9324146 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Hello,

Confirming this issue as verified fixed on macOS 13, Windows 11 and Ubuntu 22 using the Treeherder build 112.0b6(20230322151931).
Also verified with browser.urlbar.quicksuggest.blockingEnabled = false and browser.urlbar.bestMatch.blockingEnabled = false as well, per requested in Comment 4.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: