1823608 - Result menu dismiss option does NOT work for top picks and firefox suggest

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: top pick is not dismissed

Found in

• Fx 112.0b4

Affected versions

• Fx 113.0a1
• Fx 112.0b4

Affected platforms

• Windows 10
• macOS
• Ubuntu 22

Preconditions

• browser.urlbar.resultMenu set to true
• browser.urlbar.quicksuggest.blockingEnabled set to true
• browser.urlbar.merino.endpointURL to https://merinopy.services.mozilla.com/api/v1/suggest
• browser.urlbar.merino.providers to adm,top_picks
• browser.urlbar.bestMatch.enabled to true
• browser.search.region to US
• browser.urlbar.quicksuggest.dataCollection.enabled to true
• browser.urlbar.bestMatch.blockingEnabled to true

Steps to reproduce

1. Launch Firefox.
2. Type 'dell' in the address bar.
3. Using the result menu, choose the dismiss option.

Expected result

• Top pick for dell is dismissed and not shown again.

Actual result

• The top pick is not dismissed.

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=651dadff8b4864650922a5beaa0c458cfda0028d&tochange=11e6330ee0087beaec68da00bc61c30dbd4d16df
• Potentially regressed by: Bug 1822338 seems to be the regressor.

Additional notes

• Firefox suggestions dismiss does not work (sponsored or non-sponsored suggestions are not dismissed).

Comment 1

[Dão Gottwald [:dao]]

D'oh, thanks for catching this!

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1823608 - Fix and consolidate logic for whether quickSuggest and bestMatch blocking are enabled.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1822338

Comment 4

[Dão Gottwald [:dao]]

When verifying this, please also test with browser.urlbar.quicksuggest.blockingEnabled = false and browser.urlbar.bestMatch.blockingEnabled = false. As of bug 1822338, we want blocking to be enabled when the result menu is enabled, even with those prefs set to false.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac52e391141d
Fix and consolidate logic for whether quickSuggest and bestMatch blocking are enabled. r=mak

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 9324146 [details]
Bug 1823608 - Fix and consolidate logic for whether quickSuggest and bestMatch blocking are enabled.

Beta/Release Uplift Approval Request

• User impact if declined: See comment 0. Note that this would NOT affect regular users on Firefox 112, as prefs for relevant features such as browser.urlbar.quicksuggest.blockingEnabled, browser.urlbar.quicksuggest.blockingEnabled, and browser.urlbar.resultMenu default to false on release. However, a Nimbus experiment is planned for 112 where this would be an issue.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0 and comment 4.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): As I explained, this issue doesn't affect regular users, and the same would be true for the fix.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ac52e391141d

Comment 8

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Confirming this issue as verified fixed on 113.0a1(20230321213816) using macOS 13, Windows 11 and Ubuntu 22.

Verified with browser.urlbar.quicksuggest.blockingEnabled = false and browser.urlbar.bestMatch.blockingEnabled = false as well, per requested in Comment 4.

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9324146 [details]
Bug 1823608 - Fix and consolidate logic for whether quickSuggest and bestMatch blocking are enabled.

Approved for 112.0b6

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6fa25f5313a1

Comment 11

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Confirming this issue as verified fixed on macOS 13, Windows 11 and Ubuntu 22 using the Treeherder build 112.0b6(20230322151931).
Also verified with browser.urlbar.quicksuggest.blockingEnabled = false and browser.urlbar.bestMatch.blockingEnabled = false as well, per requested in Comment 4.