Closed Bug 1822338 Opened 1 year ago Closed 1 year ago

Enable quick suggest and best match blocking when the result menu is enabled

Categories

(Firefox :: Address Bar, task)

Firefox 112
Desktop
Unspecified
task

Tracking

()

VERIFIED FIXED
113 Branch
Tracking Status
firefox112 --- verified
firefox113 --- verified

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [snt-urlbar-result-menu])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1815889 +++

Due to Nimbus not yet being able to enable multiple features per experiment, we need to automatically enable quick suggest and best match blocking when the result menu is enabled.

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8526273dd69a
Enable quick suggest and best match blocking when the result menu is enabled. r=adw
Backout by abutkovits@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/188786ccec78
Backed out changeset 8526273dd69a for causing failures at browser_quicksuggest_block.js. CLOSED TREE
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4b929a47cf6a
Enable quick suggest and best match blocking when the result menu is enabled. r=adw
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec5a3cc56feb
Enable quick suggest and best match blocking when the result menu is enabled. r=adw
Flags: needinfo?(dao+bmo)

Comment on attachment 9323002 [details]
Bug 1822338 - Enable quick suggest and best match blocking when the result menu is enabled. r=adw

Beta/Release Uplift Approval Request

  • User impact if declined: Needed for the Result Menu Nimbus experiment planned for 112
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: There's a dedicated QA process for the Nimbus experiment where this will be covered
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): no change for users outside of the Nimbus experiment
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9323002 - Flags: approval-mozilla-beta?
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch

Comment on attachment 9323002 [details]
Bug 1822338 - Enable quick suggest and best match blocking when the result menu is enabled. r=adw

Approved for 112.0b4

Attachment #9323002 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Regressions: 1823608

Confirming this issue as verified fixed on 113.0a1(20230321213816) and 112.0b5(20230321175953) using macOS 13, Windows 11 and Ubuntu 22.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: