1822338 - Enable quick suggest and best match blocking when the result menu is enabled

Status: VERIFIED FIXED

(Firefox :: Address Bar, task)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1815889 +++

Due to Nimbus not yet being able to enable multiple features per experiment, we need to automatically enable quick suggest and best match blocking when the result menu is enabled.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1822338 - Enable quick suggest and best match blocking when the result menu is enabled. r=adw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8526273dd69a
Enable quick suggest and best match blocking when the result menu is enabled. r=adw

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/188786ccec78
Backed out changeset 8526273dd69a for causing failures at browser_quicksuggest_block.js. CLOSED TREE

Comment 4

[Atila Butkovits]

Backed out for causing failures at browser_quicksuggest_block.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/188786ccec780a74c8b5966b7bccd75eeffa5141

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=OGRH6dYZRey4Aayvp8ukXQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=8526273dd69aa88c4ee3646f972a794d2da32171

Failure log: https://treeherder.mozilla.org/logviewer?job_id=408977278&repo=autoland&lineNumber=4410

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b929a47cf6a
Enable quick suggest and best match blocking when the result menu is enabled. r=adw

Comment 6

[Cristina Horotan [:chorotan]]

Backed out changeset 4b929a47cf6a (bug 1822338) for causing bc failures at browser_glean_telemetry_engagement_type.js

Backout: https://hg.mozilla.org/integration/autoland/rev/ce4f6d896e2671a6eef845dcb688bf36c02c8e37

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=4b929a47cf6a58f4d4b862d1abd6fca53c2675e5

Failure log: https://treeherder.mozilla.org/logviewer?job_id=408992571&repo=autoland&lineNumber=9305

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec5a3cc56feb
Enable quick suggest and best match blocking when the result menu is enabled. r=adw

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 9323002 [details]
Bug 1822338 - Enable quick suggest and best match blocking when the result menu is enabled. r=adw

Beta/Release Uplift Approval Request

• User impact if declined: Needed for the Result Menu Nimbus experiment planned for 112
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: There's a dedicated QA process for the Nimbus experiment where this will be covered
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): no change for users outside of the Nimbus experiment
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ec5a3cc56feb

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9323002 [details]
Bug 1822338 - Enable quick suggest and best match blocking when the result menu is enabled. r=adw

Approved for 112.0b4

Comment 11

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6d9b7c9bbb41

Comment 12

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed on 113.0a1(20230321213816) and 112.0b5(20230321175953) using macOS 13, Windows 11 and Ubuntu 22.