1823779 - Refactor to evaluate screen targeting and update screens state on index change

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Punam Dahiya [:pdahiya]]

https://phabricator.services.mozilla.com/D172593 fix adds dynamic screen targeting by using isDynamic property inside handleAction. This adds an overload of maintaining isDynamic property for actions we want to evaluate targeting dynamically.

Scope of this bug is to refactor code to evaluate screen targeting on unvisited screens (screens coming after the current screen) when index changes and screen loads

useEffect(() => {
    (async () => {
      let screensVisted = screens.slice(0, index);
    setScreens(
      screensVisted.concat(
        await window.AWEvaluateScreenTargeting(screens.slice(index))
      )
    );
    })();
  }, [index]); 

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1823779 - Evaluate screen targeting and update screen state on index change

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa398d16e528
Evaluate screen targeting and update screen state on index change r=Mardak,omc-reviewers,negin

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/aa398d16e528

Comment 4

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 114.0a1 (Build ID: 20230507095340) on Windows 10 x64, macOS 11.7.1, and Ubuntu 22.04 x64.

• After following the testing steps from this Test Plan, I confirm that the “about:welcome” screens (both with language mismatch and without) show up in the correct order and have their impression pings are correctly registered in the Browser Console.