1827031 - Small pop-up window has overlapping hamburger menu button and extension menu button

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Daniel Holbert [:dholbert]]

(Spinning this off from bug 1827027 for an issue that I noticed there with a distinct regression range & with less user-interaction required -- notably, no window-resizing necessary in this bug here.)

STR:

1. Visit https://www.sfcu.org/membership-rewards/
2. Click "Live Chat" link at top left (note that your browser has to be at least ~1000px wide for it to show up)

ACTUAL RESULTS:
In the popup window that appears, the hamburger menu button and extension menu button are overlapping.

EXPECTED RESULTS:
No such overlapping buttons.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=34056df4e1d5f8a9d55691039de73456918c1bc1&tochange=e08af0bae48c1f8d7f45ce9f285b7c6378653767

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot (note the overlapping icons at top-right)

Comment 2

[Daniel Holbert [:dholbert]]

Two notes:
(1) I imagine a proper fix for bug 1827027 might prevent overlap here, but potentially still have not-enough-space & cause the hamburger icon to run off the right side of the window and be clipped.

(2) Further back in mozregression history (before we even migrated this toolbar to modern flexbox), that is actually the rendering we had here, if you manually enabled the unified extension toolbar-icon (which we show by default now). Running e.g. mozregression --launch 2022-07-25 --pref "extensions.unifiedExtensions.enabled:true" -a "https://www.sfcu.org/membership-rewards/" and clicking "Live Chat", I get a window with the hamburger menu being mostly-clipped (pushed off the right edge of the window).

Maybe one part of the fix here is that we should stop showing this extension menu in the navbar on pop-up windows like this one? That would leave enough space for the hamburger menu icon. We don't show any other toolbar icons (as you can see if you resize the window to be huge), so it's not obvious to me that the extension menu has special-importance to include here. (I could imagine e.g. potentially wanting to activate uBlock Origin or other content-modification extensions, but those don't actually show up in the extension menu!)

I'll file a separate bug on removing the extension menu from these windows; and this bug might just end up being fixed-by-that-change.

Comment 3

[BugBot [:suhaib / :marco]]

:emilio, since you are the author of the regressor, bug 1823791, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #2)

I'll file a separate bug on removing the extension menu from these windows; and this bug might just end up being fixed-by-that-change.

Filed bug 1827034. If I'm understanding things correctly, I think we can plan to have this bug just be fixed by that one.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1827031 - Fix a media query block that I forgot to update in bug 1823791. r=dao,Gijs

Comment 6

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1823791

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c8f1de13764
Fix a media query block that I forgot to update in bug 1823791. r=dao

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7c8f1de13764

Comment 9

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9327760 [details]
Bug 1827031 - Fix a media query block that I forgot to update in bug 1823791. r=dao,Gijs

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix, see regressing bug.
• String changes made/needed: none
• Is Android affected?: No

Comment 11

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Comment on attachment 9327760 [details]
Bug 1827031 - Fix a media query block that I forgot to update in bug 1823791. r=dao,Gijs

Approved for 113 beta 3, thanks.

Comment 12

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

https://hg.mozilla.org/releases/mozilla-beta/rev/077496c601e4

Comment 13

[Ciprian Georgiu, Desktop QA]

I have reproduced this bug using an affected Nightly build from 2023-04-07, on macOS 11.

The issue is verified as fixed on latest Nightly 114.0a1, and Beta 113.0b3 under Win 7 x64, macOS 11 and Ubuntu 18.04 x64.

Comment 14

[Daniel Holbert [:dholbert]]

Note: it turns out this overlap was reproducible in regular windows as well (not just popups), if you shrink them to be as skinny as they'll allow. bug 1827027 comment 17 shows an example.

(I've confirmed that this overlap in regular windows no longer happens in latest Nightly, and the fix range (from mozregression) is just the commit for this bug.)