Closed Bug 1824140 Opened 1 year ago Closed 1 year ago

Urlbar picture-in-picture button can be activated by right clicking

Categories

(Toolkit :: Picture-in-Picture, defect, P2)

Firefox 113
defect

Tracking

()

VERIFIED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: blakewolf, Assigned: niklas)

References

Details

Attachments

(1 file)

Steps to reproduce:

Right clicking the "toggle picture-in-picture" button activates PIP

Expected results:

Right clicking should not active PIP. Right clicking does not active Reader or Translate

The Bugbug bot thinks this bug should belong to the 'Toolkit::Picture-in-Picture' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Picture-in-Picture
Product: Firefox → Toolkit
Severity: -- → S3
Priority: -- → P3
Summary: Toggle picture-in-picture can be activated by right clicking → Urlbar picture-in-picture button can be activated by right clicking
Duplicate of this bug: 1824709
Priority: P3 → P2
Blocks: 1811318
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/acde77999561
Only allow left click on PiP urlbar button. r=pip-reviewers,mhowell
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Flags: qe-verify+

Reproduced the issue with Firefox 113.0a1 (2023-03-23) on macOS 12 and Windows 10. Indeed when viewing a page with a single video, right clicking on the pip toggle from the urlbar will activate the pip (for the button to appear, make sure you have the media.videocontrols.picture-in-picture.urlbar-button.enabled pref enabled).
The issue is verified fixed with Firefox 114.0a1 (20230426170915) and Firefox 113.0b8 (20230425192707) on Windows 10, macOS 12, and Ubuntu 22.
Right clicking on the pip toggle from the urlbar will not activate the pip, as expected.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: