Closed
Bug 1824197
Opened 1 year ago
Closed 8 months ago
Implement "browsingContext.handleUserPrompt" command
Categories
(Remote Protocol :: WebDriver BiDi, enhancement, P1)
Remote Protocol
WebDriver BiDi
Tracking
(firefox118 fixed)
RESOLVED
FIXED
118 Branch
| Tracking | Status | |
|---|---|---|
| firefox118 | --- | fixed |
People
(Reporter: whimboo, Assigned: Sasha)
References
(Blocks 3 open bugs, )
Details
(Whiteboard: [webdriver:m8][wptsync upstream][webdriver:relnote])
Attachments
(5 files)
Implementation of this bug should cover simple dialogs like alert, prompt, and confirm.
We should be able to partly re-use the code from Marionette and make the modal.sys.mjs module a shared module for both protocols.
Note that we currently disable beforeunload prompts completely in Marionette. As such we should work on support for this event in a different bug so that we can also fix the behavior for Marionette at the same time.
|
Reporter | |
Updated•1 year ago
|
Points: --- → 5
Priority: -- → P2
Whiteboard: [webdriver:backlog]
|
|
Reporter | |
Updated•1 year ago
|
Priority: P2 → P1
Whiteboard: [webdriver:backlog] → [webdriver:m7]
|
|
Reporter | |
Updated•1 year ago
|
Priority: P1 → P2
|
|
Reporter | |
Updated•10 months ago
|
Whiteboard: [webdriver:m7] → [webdriver:m8]
|
Assignee | |
Updated•9 months ago
|
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•9 months ago
|
Priority: P2 → P1
|
|
Assignee | |
Comment 1•9 months ago
|
||
|
|
Assignee | |
Comment 2•9 months ago
|
||
Depends on D185552
|
|
Assignee | |
Comment 3•9 months ago
|
||
Depends on D185553
|
|
Assignee | |
Comment 4•9 months ago
|
||
Depends on D185554
|
||
Updated•9 months ago
|
Attachment #9347668 -
Attachment description: Bug 1824197 - [wdpspec] Add support for "browsingContext.handleUserPrompt" to bidi test client. → Bug 1824197 - [wdspec] Add support for "browsingContext.handleUserPrompt" to bidi test client.
|
|
||
Updated•9 months ago
|
Attachment #9347669 -
Attachment description: Bug 1824197 - [wdpspec] Add tests for "browsingContext.handleUserPrompt" command. → Bug 1824197 - [wdspec] Add tests for "browsingContext.handleUserPrompt" command.
|
|
||
Updated•9 months ago
|
Attachment #9347666 -
Attachment description: Bug 1824197 - Move Modal to a shared module. → Bug 1824197 - Move Modal class to a shared module and rename it to Prompt.
|
|
Assignee | |
Comment 5•9 months ago
|
||
Depends on D185552
|
|
||
Updated•9 months ago
|
Attachment #9347669 -
Attachment description: Bug 1824197 - [wdspec] Add tests for "browsingContext.handleUserPrompt" command. → Bug 1824197 - [wdspec] Add invalid tests for "browsingContext.handleUserPrompt" command.
Pushed by aborovova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9e741c05934f Move Modal class to a shared module and rename it to Prompt. r=webdriver-reviewers,jdescottes https://hg.mozilla.org/integration/autoland/rev/f49f4b5ea66d Rename `findModalDialogs` method. r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/30b7743883ac [bidi] Implement "browsingContext.handleUserPrompt" command. r=webdriver-reviewers,jdescottes,whimboo https://hg.mozilla.org/integration/autoland/rev/e6c05b12e989 [wdspec] Add support for "browsingContext.handleUserPrompt" to bidi test client. r=webdriver-reviewers,jdescottes,whimboo https://hg.mozilla.org/integration/autoland/rev/35f5ffd4f473 [wdspec] Add invalid tests for "browsingContext.handleUserPrompt" command. r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41467 for changes under testing/web-platform/tests
|
||
Updated•8 months ago
|
Whiteboard: [webdriver:m8] → [webdriver:m8], [wptsync upstream]
|
||
Comment 8•8 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9e741c05934f
https://hg.mozilla.org/mozilla-central/rev/f49f4b5ea66d
https://hg.mozilla.org/mozilla-central/rev/30b7743883ac
https://hg.mozilla.org/mozilla-central/rev/e6c05b12e989
https://hg.mozilla.org/mozilla-central/rev/35f5ffd4f473
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox118:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
Upstream PR merged by moz-wptsync-bot
|
|
Reporter | |
Updated•7 months ago
|
Whiteboard: [webdriver:m8], [wptsync upstream] → [webdriver:m8][wptsync upstream][webdriver:relnote]
You need to log in
before you can comment on or make changes to this bug.
Description
•