1824197 - Implement "browsingContext.handleUserPrompt" command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Implementation of this bug should cover simple dialogs like alert, prompt, and confirm.

We should be able to partly re-use the code from Marionette and make the modal.sys.mjs module a shared module for both protocols.

Note that we currently disable beforeunload prompts completely in Marionette. As such we should work on support for this event in a different bug so that we can also fix the behavior for Marionette at the same time.

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1824197 - Move Modal class to a shared module and rename it to Prompt.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1824197 - [bidi] Implement "browsingContext.handleUserPrompt" command.

Depends on D185552

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1824197 - [wdspec] Add support for "browsingContext.handleUserPrompt" to bidi test client.

Depends on D185553

Comment 4

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1824197 - [wdspec] Add invalid tests for "browsingContext.handleUserPrompt" command.

Depends on D185554

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1824197 - Rename `findModalDialogs` method.

Depends on D185552

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e741c05934f
Move Modal class to a shared module and rename it to Prompt. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/f49f4b5ea66d
Rename `findModalDialogs` method. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/30b7743883ac
[bidi] Implement "browsingContext.handleUserPrompt" command. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/e6c05b12e989
[wdspec] Add support for "browsingContext.handleUserPrompt" to bidi test client. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/35f5ffd4f473
[wdspec] Add invalid tests for "browsingContext.handleUserPrompt" command. r=webdriver-reviewers,whimboo

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41467 for changes under testing/web-platform/tests

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9e741c05934f
https://hg.mozilla.org/mozilla-central/rev/f49f4b5ea66d
https://hg.mozilla.org/mozilla-central/rev/30b7743883ac
https://hg.mozilla.org/mozilla-central/rev/e6c05b12e989
https://hg.mozilla.org/mozilla-central/rev/35f5ffd4f473

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot