Closed Bug 1824197 Opened 1 year ago Closed 7 months ago

Implement "browsingContext.handleUserPrompt" command

Categories

(Remote Protocol :: WebDriver BiDi, enhancement, P1)

enhancement
Points:
5

Tracking

(firefox118 fixed)

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

References

(Blocks 3 open bugs, )

Details

(Whiteboard: [webdriver:m8][wptsync upstream][webdriver:relnote])

Attachments

(5 files)

Implementation of this bug should cover simple dialogs like alert, prompt, and confirm.

We should be able to partly re-use the code from Marionette and make the modal.sys.mjs module a shared module for both protocols.

Note that we currently disable beforeunload prompts completely in Marionette. As such we should work on support for this event in a different bug so that we can also fix the behavior for Marionette at the same time.

Points: --- → 5
Priority: -- → P2
Whiteboard: [webdriver:backlog]
Priority: P2 → P1
Whiteboard: [webdriver:backlog] → [webdriver:m7]
Priority: P1 → P2
Blocks: 1763134
Whiteboard: [webdriver:m7] → [webdriver:m8]
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Priority: P2 → P1
Attachment #9347668 - Attachment description: Bug 1824197 - [wdpspec] Add support for "browsingContext.handleUserPrompt" to bidi test client. → Bug 1824197 - [wdspec] Add support for "browsingContext.handleUserPrompt" to bidi test client.
Attachment #9347669 - Attachment description: Bug 1824197 - [wdpspec] Add tests for "browsingContext.handleUserPrompt" command. → Bug 1824197 - [wdspec] Add tests for "browsingContext.handleUserPrompt" command.
Attachment #9347666 - Attachment description: Bug 1824197 - Move Modal to a shared module. → Bug 1824197 - Move Modal class to a shared module and rename it to Prompt.

Depends on D185552

Attachment #9347669 - Attachment description: Bug 1824197 - [wdspec] Add tests for "browsingContext.handleUserPrompt" command. → Bug 1824197 - [wdspec] Add invalid tests for "browsingContext.handleUserPrompt" command.
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e741c05934f
Move Modal class to a shared module and rename it to Prompt. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/f49f4b5ea66d
Rename `findModalDialogs` method. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/30b7743883ac
[bidi] Implement "browsingContext.handleUserPrompt" command. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/e6c05b12e989
[wdspec] Add support for "browsingContext.handleUserPrompt" to bidi test client. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/35f5ffd4f473
[wdspec] Add invalid tests for "browsingContext.handleUserPrompt" command. r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41467 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m8] → [webdriver:m8], [wptsync upstream]
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m8], [wptsync upstream] → [webdriver:m8][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.