1763134 - Handle navigation which trigger beforeunload prompts for browsingContext.navigate

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

Follow up to handle more specific navigation use cases.
We should support navigation which trigger a beforeunload prompt

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

For now this is blocked on the ability to handle user prompts. This feature will be added as part of bug 1768170.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Julian, do you remember which use cases you had in mind? We could at least check the disabled Puppeteer unit tests and try to get those running. AFAIR there are as well scenarios with history.pushState(), redirects, and most likely others.

Comment 3

[Julian Descottes [:jdescottes]]

Sorry I don't really remember specific scenarios. I just remember we couldn't check beforeunload at all at that time because bidi did not support it.
I think at least checking that a navigation with a dismissed beforeunload prompt would be a good start. Ideally then also test what happens when the navigation is cancelled.

Regarding other scenarios, yes we can add history navigation and redirects.

Comment 4

[Alexandra Borovova [:Sasha]]

In the scope of this bug, we should cover two cases:

• if the navigate command was started with wait argument equal none when beforeunload prompt is open, we should return from the navigate command;
• if the beforeunload prompt was dismissed, we should fail navigate command with unknown error.

Comment 5

[Alexandra Borovova [:Sasha]]

It looks like that implementation-wise, it's easier to keep this bug just about the case of returning from the navigation command when it is started with wait argument equal none and when beforeunload prompt is open and move the case of failing the command to bug 1905083.

Comment 6

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1763134 - Stop navigation with "wait" equal "none" when beforeunload prompt is open.

Comment 7

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1763134 - [wdspec] Add test for navigation with "wait" equal "none" and beforeunload prompt open.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/619dddf77a31
Stop navigation with "wait" equal "none" when beforeunload prompt is open. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/d3ff8ea02d53
[wdspec] Add test for navigation with "wait" equal "none" and beforeunload prompt open. r=webdriver-reviewers,jdescottes

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47463 for changes under testing/web-platform/tests

Comment 10

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/619dddf77a31
https://hg.mozilla.org/mozilla-central/rev/d3ff8ea02d53

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot