18242 - [DOGFOOD] All graphic(icons)on the toolbar are gone after hitting Stop while downloading a message

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[marina]

Say you have a message with an attachement and it is loading slowly and you hit
stop to stop downloading it. Now look at your toolbar bar :there is a redraw
problem with all icon images-they are gone and in the thread pane scroll bar and
message icons look like they didn't completely loaded.
Steps to reproduce:
-open Inbox ;
-click on the message that has a Web page (displayed on-line);
-stop downloading by clicking "Stop";
-//note: icons on the toolbar for "Get Mail", "New Mail", "Reply" etc have
disapeared and in the thread you'll see some redraw problems

Comment 1

[marina]

forgot to mention : it was observed with today's 1999-11-08-09 M11 win build (it
happens on IMAP and POP

Comment 2

[Phil Peterson]

bienvenu sez this is rpotts' problem.

Comment 3

[Phil Peterson]

*** Bug 18376 has been marked as a duplicate of this bug. ***

Comment 4

[leger]

Putting on M12 radar.

Comment 5

[rpotts (gone)]

Moving milestones...

Comment 6

[Phil Peterson]

Nominating for dogfood since bug 21075 is marked PDT+

Comment 7

[Phil Peterson]

*** Bug 21075 has been marked as a duplicate of this bug. ***

Comment 8

[lchiang]

In the other bug, it was assigned to hangas with comments from evaughan.

Comment 9

[Ninoschka Baca]

adding nbaca to Cc: list.

Comment 10

[leger]

Putting on the PDT+ radar.

Comment 11

[rpotts (gone)]

hey david,
Is this *really* my bug?  it sounds like the toolbar images are being loaded in
the same load group as the message (which would be bad).  This could cause the
toolbar images to get interrupted (if they were loading) when the stop button
was pressed...

I can't imagine what the loadgroup would be doing that could cause this :-(

-- rick

Comment 12

[Peter Trudelle]

Could this be a side effect of IMAP and the UI executing events on the wrong
threads?  This is described in 17065 and 18005, for which DougT has a fix
available as a patch.

Comment 13

[(not reading, please use [e-mail] instead)]

I can reproduce the problem.

I'll try dougt's posted patch for nsEventQueue.cpp now...

Comment 14

[(not reading, please use [e-mail] instead)]

nope, dougt's patch doesn't fix this.

Comment 15

[David :Bienvenu]

rick, sorry if this isn't your bug - I was going on what you told me when I
described this bug to you :-) We are using the root web shell's load group, so
that we can stop any url running in our window. But the thing is that the images
are not getting loaded when I press stop - they disappear after I mouse over
them long after pressing stop.  Unless pressing stop causes them to get reloaded
while we're stopping. I'm not sure what load group the toolbar images are using.
We could create our own load group. Or we could just cancel the load group and
not stop the web shell. I'll try that last thing and see if that makes a
difference.

Comment 16

[David :Bienvenu]

OK, just cancelling the loadgroup doesn't show this problem. I'll take the bug.

Comment 17

[laurel]

OK using 12-13-09m12 commercial builds on linux 6.0, mac OS 8.5.1 and NT 4.0

Comment 18

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/873d1b55a806
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18242 - Wire up "Sync cards across devices" preference with SyncPreferenceView (https://github.com/mozilla-mobile/fenix/pull/18605)