1826881 - Bottom of window: statusbar etc. not shown. `Tasks` subsection lost `Click here to add a new task` button with `Events and Tasks` in `Today Pane`

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Beta still has the button to add a task, lost on Daily, plus app window cut off in restored window size

With Events and Tasks in Today Pane, the Tasks subsection lost Click here to add a new task button (see screenshot): Beta still has the button to add a task, lost on Daily.

Alice, if you have time, having a regression window might help.

Also, when restoring the Thunderbird window to window size, the entire bottom of the window is just cut off and missing, and scrollbars scroll into nowhere, as the entire UI isn't recalculated/adjusted. Which may or may not be the cause here, because even in maximized window state, the button still won't come back.

Comment 1

[Alice0775 White]

Steps to reproduce:

1. Start TB w/ new profile
2. Set Up your Email Address
3. When System Integration dialog pops up, Skip Integration
4. Calendar (Alt+3) tab And click ENABLE
5. Click on 'Click here to add new task'
6. Type a title of new task and hit Enter
   --- Nothing appear added new task, see Bug 1826959
7. Click < then > then <
   --- BUG!! 'Click here to add new task' button is missing. still no task, see Bug 1826959

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=fe6bde73e9fe159ddab4b678fedc57a5cb27e727&tochange=de9b191c05a1351ce261973a29072e5aee9b6fdb

Tentatively, set Bug 1824767 is as regressor

Comment 2

[Geoff Lankow (:darktrojan)]

I can reproduce this with or without bug 1824767. Seems like the layout code is refusing to let the tasks tree shrink. It's much more likely to be a flexbox regression.

Comment 3

[Magnus Melin [:mkmelin]]

I was wondering why the bottom of the window (status bar and stuff) was occasionally missing.
Strangely, it seems to happen for me simply by going to the calendar tab and the back to the mail tab, if I have "events and tasks" showing i mail (and lots of tasks/events).

Comment 4

[Geoff Lankow (:darktrojan)]

I strongly suspect bug 1824957 which is within the regression range. It's also when comm/mailnews/extensions/newsblog/test/browser/browser_feedDisplay.js started to fail on Mac, and that too is because of a tree that can get bigger but refuses to get smaller. Emilio?

Comment 5

[Magnus Melin [:mkmelin]]

Maybe https://hg.mozilla.org/comm-central/rev/b1ee48cc7d4a#l3.12 is relevant

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1826881 - Fix suspicious tree invalidation code. r=jwatt,TYLin,dholbert,#layout

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Sounds plausible. Does comment 6 help?

Comment 8

[Geoff Lankow (:darktrojan)]

It works for me locally. I'll do a Try run to double-check, but I assume everything will be fine. Thank you!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bc08cb02f41
Fix suspicious tree invalidation code. r=dholbert

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0bc08cb02f41

Comment 12

[Magnus Melin [:mkmelin]]

Can we uplift to beta?

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9327906 [details]
Bug 1826881 - Fix suspicious tree invalidation code. r=jwatt,TYLin,dholbert,#layout

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Improves invalidation of <tree> elements. It's a well-contained change which for Firefox at most would only make performance of library window or history sidebars slightly worse on resize (but that's unlikely in practice).
• String changes made/needed: none
• Is Android affected?: No

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1824957

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9327906 [details]
Bug 1826881 - Fix suspicious tree invalidation code. r=jwatt,TYLin,dholbert,#layout

Approved for 113.0b5.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cedf3d45307b