Closed
Bug 1825058
Opened 3 years ago
Closed 2 years ago
Handle the case where a user clicks on a non-ad link on a SERP
Categories
(Firefox :: Search, task, P2)
Firefox
Search
Tracking
()
RESOLVED
FIXED
116 Branch
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: scunnane, Assigned: scunnane)
References
Details
Attachments
(1 file)
The SERP abandonment event patch introduces an impressionIdsWithoutEngagementsSet, which currently is not updated to reflect a click on a non-ad link on a SERP. This needs to be updated.
|
||
Updated•2 years ago
|
Severity: -- → N/A
Priority: -- → P3
|
|
||
Updated•2 years ago
|
Priority: P3 → P2
|
||
Comment 1•2 years ago
|
||
This should be address by our observance of non ad links being clicked in SearchSERPTelemetry once Bug 1816730 lands. I have tests that check that we are registering non ads clicked correctly but you may also want to add a test that ensures we're not recording an abandonment if a non-ads is clicked.
|
Assignee | |
Comment 2•2 years ago
|
||
|
||
Updated•2 years ago
|
Attachment #9338118 -
Attachment description: WIP: Bug 1825058 - Add test to verify a click on a non-ad link does not record an abandonment event. → Bug 1825058 - Add test to verify a click on a non-ad link does not record an abandonment event. r?jteow
Pushed by scunnane@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97ed2fb9c5d3
Add test to verify a click on a non-ad link does not record an abandonment event. r=jteow,search-reviewers
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox116:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•