1825207 - Subtitles are not displayed in PiP on TubiTV live streams

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Peter Magyari (Desktop QA)]

Found in

• Nightly 113.0a1

Affected versions

• Beta 112.0b7
• Release 11.0.1

Affected platforms

• All

Steps to reproduce

1. Make sure to use a VPN if not from the US.
2. Navigate to www.tubitv.com/live
3. Choose a live-stream from the available ones.
4. Make sure you have subtitles (CC) activated.
5. Launch live-stream in PiP mode.

Expected result

• The subtitles should be displayed in PiP.

Actual result

• The subtitles are not displayed in PiP.

Regression range

• This is not a recent regression.

Additional notes

• Subtitles are properly displayed in PiP in the case of videos that aren't live.

Comment 1

[Peter Magyari (Desktop QA)]

Attachment: live fwd-bck.jpg

Additional Note

• Progress bar and Forwards/Backward buttons are also available while watching liveTV.

Comment 2

[kpatenio]

For TubiTV live, we're able to utilize the textTracks video property to detect active cues. We support this property in the PiPChild. However, the cues are set to hidden mode since TubTV live allows for customizing captions appearance.

We only support showing mode tracks at the moment, but there is ongoing work to support hidden tracks in Bug 1754549.

Comment 3

[kpatenio]

Attachment: Bug 1825207 - add subtitles support for TubiTV live. r=#pip-reviewers!,dwalker!

Comment 4

[kpatenio]

While the override showHiddenTextTracks works in showing captions on TubiTV live videos, captions are still displayed on the PiP window when TubiTV live cc is disabled since the text track mode remains as hidden (thus never triggering the change event). Unfortunately I didn't realize this until I started working on a patch. The easiest workaround probably would be to detect captions via a site-specific wrapper. We already have a wrapper for tubiTV, but we might want a separate one unique to tubiTV live given Bug 1828705.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fb145fdba3e
add subtitles support for TubiTV live. r=pip-reviewers,dwalker,mhowell

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1fb145fdba3e

Comment 7

[Peter Magyari (Desktop QA)]

I have verified the fix using Nightly 115.0a1 (20230508214159) on Window 10, MacOS 11 and Ubuntu 20.04.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 9

[kpatenio]

Is a11y-review needed here? The patch merely adds a script to support visually displaying captions on TubiTV Live, which we've done for other sites that previously did not require a11y-review. It also shouldn't impact accessibility of keyboard tabbing, screen readers, etc.

Comment 10

[Andrew McCreight [:mccr8]]

It is just some spammer or would be security tester.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kpatenio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.