1825413 - Add Telemetry for Pull to Refresh

Status: VERIFIED FIXED

(Fenix :: Experimentation and Telemetry, enhancement, P2)

Description

[Channing]

Add the following telemetry for Pull to Refresh on Firefox Android:

• Pull to refresh enabled
• Pull to refresh executed

Actual behavior

• There is no telemetry around this feature

Device information

• Firefox version:
• Android device model:
• Android OS version:

Any additional information?

Comment 2

[Jonathan Almeida [:jonalmeida]]

Moving tracking flags from duplicate issue.

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1825413 - Add Telemetry for Pull to Refresh (#1775)

Comment 4

[Joe M [:jmahon]]

Note from the dupe bug: we want to backport this telemetry to v113 and v112.

Comment 5

[Joe M [:jmahon]]

Actually, sorry, it won't matter if we backport this into v112 at this point, since there's no more planned dot releases before v113 enters the Release channel.

We should still uplift to v113 as soon as this is landed, even if it just gets us a week or so of insight about the beta channel usage.

Comment 6

[BMO Github Automation]

Authored by https://github.com/iorgamgabriel
https://github.com/mozilla-mobile/firefox-android/commit/d59677c4c2f5462232bc3b4998a05e197927a2d8
[main] Bug 1825413 - Add Telemetry for Pull to Refresh

Comment 7

[Ryan VanderMeulen [:RyanVM]]

We've already built the final Fenix beta of the cycle. Is this something we still want to uplift to v113 for the RC build Monday?

Comment 8

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1825413 - Add Telemetry for Pull to Refresh (backport #1775) (#1822)

Comment 9

[Jonathan Almeida [:jonalmeida]]

Comment on attachment 9330179 [details] [review]
[mozilla-mobile/firefox-android] Bug 1825413 - Add Telemetry for Pull to Refresh (#1775)

Beta/Release Uplift Approval Request

• User impact if declined: No user impact; telemetry only change.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a change to collect telemetry and should not be risky as a result.
• String changes made/needed: n/a
• Is Android affected?: Yes

Comment 10

[Joe M [:jmahon]]

Shoot, :RyanVM, I thought I responded to this on Friday - it's pretty low-risk, so if it's still possible to get into v113, that'd be great, but not a big deal if it misses the build & gets into the first v113 dot release instead.

NI-ing you just to help make sure you see this, since I know it's a time-sensitive response. Feel free to clear the NI with an answer of whether or not it made it to v113!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9330179 [details] [review]
[mozilla-mobile/firefox-android] Bug 1825413 - Add Telemetry for Pull to Refresh (#1775)

Thanks, approved for 113.0rc1.

Comment 12

[BMO Github Automation]

Authored by https://github.com/iorgamgabriel
https://github.com/mozilla-mobile/firefox-android/commit/fc9bd78432addb784e7ba390a4c65892f84a9d97
[releases_v113] Bug 1825413 - Add Telemetry for Pull to Refresh

Comment 13

[Andrei Mocirean]

Verified as fixed on the latest Nightly from 2nd of May (114.0a1) and latest RC (113.0).
All the events and metrics are sent as intended.
Devices used for testing: Lenovo Tab P11 Plus (Android 12), Google Pixel 7 Pro (Android 13).