1825436 - With active search with no matching buttons in Unified toolbar customization dialog, cannot drag any buttons off the toolbar

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect, P3)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot: Active search, no results any more, then dragging any button off the toolbar fails

+++ This bug was initially created as a clone of Bug #1825281 +++

When there's an active search in Unified toolbar customization dialog which happens to have no matches currently (all matching buttons on toolbar, or no matches), no button can be removed from toolbar. The UX is quite unpredictable: Will sometimes work (as long as there's a single result from the button's origin section still shown), and sometimes not, without any apparent reason for the user. This is related to bug 1825281 and would hopefully be covered there, as the proposed solution is the same: Just dropping a button outside the toolbar area should suffice to remove it.

STR

• Right-click on Unified Toolbar > Customize…
• Drag some buttons from both sections onto the toolbar.
• Enter a unique button label into the search field, e.g. Delete.
  => the button is the only result.
• Drag the Delete button onto the toolbar.
  => No buttons left in search result
• Try to drag any button (even the Delete button) off the toolbar for removal while the search is still active.

Actual result

• If a stock section does no longer have any buttons matching the search (because there are no matches or the matching buttons are all on the toolbar), it's not possible to remove any buttons belonging to that section while the search is still active.
• If both stock sections are empty from an active search, no button can be removed from the toolbar as long as the search is active, not even buttons matching the search. Iow, if user changes his mind and wants to reverse adding the Delete button (only search result), it's not possible before clearing the search (for which there's really no reason).
• This makes removing buttons unnecessarily clumsy for no apparent reason.

Expected result

• Kindly simplify removing buttons from the toolbar:
  • Dragging and dropping any button anywhere outside the toolbar should always remove it, regardless of active search with or without other matches.

From Bug 1825281 Comment 0:

Removing a button from the Unified toolbar target in the customization dialog is a bit difficult and should be simplified - just dragging it off the toolbar should suffice to remove it, and we should take care of the rest automatically (putting the button back into the right section of the button stock where it belongs).

Comment 1

[Wayne Mery (:wsmwk)]

Drag and drop works, but sometimes save button is not activated.
Fails inconsistently - but perhaps someone else can find a pattern.
Nothing in error console.

Comment 2

[Thomas D. (:thomas8)]

(In reply to Wayne Mery (:wsmwk) from comment #1)

Drag and drop works, but sometimes save button is not activated.

Well this bug reports that drag and drop does not always work.

• You need advanced knowledge to know the exact category of each button because you can't just drag them off, you need to drag them back to their fold (which is just annoying, and so implementation-centered).
• Depending on scenario, especially with active button search, you won't have any place to drag them off to, if there's no more matching or available buttons which aren't on the toolbar yet. Because then the button's home fold may be empty and thus no longer available as a drop target, so you cannot remove the button.

Fails inconsistently - but perhaps someone else can find a pattern.
Nothing in error console.

Failure to save the customization should have its own bug if we don't have one yet.

Comment 3

[Alessandro Castellani [:aleca]]

This has been fixed