1825561 - Integrate the resistfingerprinting check with the ETP Toggle.

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task)

Description

[Tim Huang[:timhuang]]

We want to integrate the resist fingerprinting check with ETP toggle so that disabling ETP protection using ETP toggle will disable fingerprinting protection of the domain.

We need to do the ContentBlockingAllowList check when checking the fingerprinting resistance of the document.

Comment 1

[Tom Ritter [:tjr] (ooto until 9/1)]

Attachment: Bug 1825561: Add in the ETP Toggle check to the ShouldRFP callgraph r?timhuang

Depends on D174150

Comment 2

[Tom Ritter [:tjr] (ooto until 9/1)]

Attachment: WIP: Bug 1825561: WIP WIP Add a test for the ETP toggle

Depends on D174166

Comment 3

[BugBot [:suhaib / :marco]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D174166	Bug 1825561: Add in the ETP Toggle check to the ShouldRFP callgraph r?timhuang	tjr	timhuang: Back Apr 10, 2023

:tjr, could you please find another reviewer?

For more information, please visit auto_nag documentation.

Comment 4

[Tom Ritter [:tjr] (ooto until 9/1)]

Attachment: Bug 1825561: Add a test for the ETP toggle exempting RFP r?timhuang

Comment 5

[Tom Ritter [:tjr] (ooto until 9/1)]

Attachment: Bug 1825561: Add a test for FPP r?timhuang

This adds the infrastructure for a simpleFPP test into head.js

Then it adds the test for browser_hwconcurrency_etp_iframes.js
that behaves differently from the simpleRFP test.

And then it adds the simpleFPP test to every hardware concurrency
test just to double check things.

Depends on D179108

Comment 6

[Tom Ritter [:tjr] (ooto until 9/1)]

Attachment: Bug 1825561: Refactor the test suite harness to support PBM tests, and add some to the ETP test r?timhuang

I had to trial-and-error my way through using BrowserTestUtils
but I think the result is a bit easier to read and understand.
Although the diff is pretty ugly.

Depends on D179249

Comment 7

[Tom Ritter [:tjr] (ooto until 9/1)]

Attachment: Bug 1825561: Add a test case for the weird RFP/FPP combination case r?timhuang

Depends on D179250

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb7c3fa32d4e
Add in the ETP Toggle check to the ShouldRFP callgraph r=timhuang
https://hg.mozilla.org/integration/autoland/rev/de3d672cc99f
Add a test for the ETP toggle exempting RFP r=timhuang
https://hg.mozilla.org/integration/autoland/rev/ab32b5ba8630
Add a test for FPP r=timhuang
https://hg.mozilla.org/integration/autoland/rev/dd380d69c705
Refactor the test suite harness to support PBM tests, and add some to the ETP test r=timhuang
https://hg.mozilla.org/integration/autoland/rev/3b9eec97301a
Add a test case for the weird RFP/FPP combination case r=timhuang

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/eb7c3fa32d4e
https://hg.mozilla.org/mozilla-central/rev/de3d672cc99f
https://hg.mozilla.org/mozilla-central/rev/ab32b5ba8630
https://hg.mozilla.org/mozilla-central/rev/dd380d69c705
https://hg.mozilla.org/mozilla-central/rev/3b9eec97301a

Comment 10

[Tom Ritter [:tjr] (ooto until 9/1)]

[Tracking Requested - why for this release]: This patchset is not strictly necessary for Tor Browser. However I would like to uplift it to ESR 115 because it significantly changes a bunch of files that will be modified over the lifespan of ESR 115 and it will make rebasing patches much easier for us and/or Tor. Most of the changes are in tests, so it has pretty good test coverage.

Comment 11

[Tom Ritter [:tjr] (ooto until 9/1)]

Sorry, wrong flag.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Happy to take these, but we're going to need approval requests still.

Comment 13

[Tom Ritter [:tjr] (ooto until 9/1)]

Attachment: Bug 1825561: Add in the ETP Toggle check to the ShouldRFP callgraph (ESR) r=timhuang

Comment 14

[Tom Ritter [:tjr] (ooto until 9/1)]

Comment on attachment 9343777 [details]
Bug 1825561: Add in the ETP Toggle check to the ShouldRFP callgraph (ESR) r=timhuang

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: It will make it easier for Tor (and us) to rebase patches onto ESR 115
• User impact if declined: Tor does more work, (and maybe us too.)
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fingerprinting Protection is not enabled in ESR 115. And we have a lot of tests.

Comment 15

[Tom Ritter [:tjr] (ooto until 9/1)]

The ESR 115 Landing Order is Bug 1825561 -> Bug 1835099 -> Bug 1842678

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9343777 [details]
Bug 1825561: Add in the ETP Toggle check to the ShouldRFP callgraph (ESR) r=timhuang

Approved for 115.1esr.

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/26391d532b16

Comment 18

[Simona Badau, Desktop QA, PTO 14-27aug]

Verified as fixed on Nightly 117.0a1 - disabling/enabling the ETP toggle disables/enables the fonts and canvas randomization protections - verified on Windows 11, macOS 12, and Ubuntu 22.04.