1842678 - About URLS incorrectly exempted

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P2)

Description

[Tom Ritter [:tjr] (OOTO until mid-August)]

In the uncommon flow, I noticed we were not returning the correct thing for about: urls that should not be exempted.

Comment 1

[Tom Ritter [:tjr] (OOTO until mid-August)]

Attachment: Bug 1842678: Exempt non-content about: urls r?timhuang

This code path is in the uncommon case, mostly
applicable to service workers I think. Test Coverage
shows it's not hit in our current suite.

Comment 2

[Tom Ritter [:tjr] (OOTO until mid-August)]

Attachment: Bug 1842678: Add a bunch of RFP logging for debugging purposes r?timhuang

Depends on D183195

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29825d05469c
Exempt non-content about: urls r=timhuang
https://hg.mozilla.org/integration/autoland/rev/179417d82498
Add a bunch of RFP logging for debugging purposes r=timhuang

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing failures on browser_navigator_iframes.js

Backout link

Push with failures

Failure log

Another failure appeared: https://treeherder.mozilla.org/logviewer?job_id=422305785&repo=autoland&lineNumber=3052

Comment 6

[Tom Ritter [:tjr] (OOTO until mid-August)]

Yay for tests! Found the bug.

Comment 7

[Tom Ritter [:tjr] (OOTO until mid-August)]

[Tracking Requested - why for this release]: I would like to uplift this patch to ESR 115 for Tor

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab982d04bf3b
Exempt non-content about: urls r=timhuang
https://hg.mozilla.org/integration/autoland/rev/74d4cd8210dd
Add a bunch of RFP logging for debugging purposes r=timhuang

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ab982d04bf3b
https://hg.mozilla.org/mozilla-central/rev/74d4cd8210dd

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tjr, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox116 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Tom Ritter [:tjr] (OOTO until mid-August)]

Attachment: Bug 1842678: Exempt non-content about: urls and add debug logging (ESR) r=timhuang

Depends on D183524

Comment 12

[Tom Ritter [:tjr] (OOTO until mid-August)]

Comment on attachment 9343779 [details]
Bug 1842678: Exempt non-content about: urls and add debug logging (ESR) r=timhuang

The ESR 115 Landing Order is Bug 1825561 -> Bug 1835099 -> Bug 1842678

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This code is needed for service workers and about: pages to have RFP correctly applied to them.
• User impact if declined: Tor will need to carry this patch
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This code only affects users with RFP enabled.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9343779 [details]
Bug 1842678: Exempt non-content about: urls and add debug logging (ESR) r=timhuang

Approved for 115.1esr.

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/cb4eb7a6d308