1825869 - Reenable 5 OpenPGP tests that were disabled in bug 1803255

Status: ASSIGNED

(MailNews Core :: Security: OpenPGP, defect, P2)

Description

[Kai Engert (:KaiE:)]

Bug 1803255 disabled 5 tests in this commit:
https://hg.mozilla.org/comm-central/rev/c3a42d3207784ca2e0c6f3c596719ac43e2467f5

Search for: .skip()

They should be reenabled.

Comment 1

[Kai Engert (:KaiE:)]

When enabling them, one of the tests reaches function MsgOpenEMLFile in mailWindowOverlay.js

After adding a missing import for MailConsts, it fails with document.getElementById("tabmail") being null.

What's missing to get that working again?

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1825869 - Reenable tests for OpenPGP functionality that is actually not broken. r=kaie.

This makes the tests technically work. There are test failures though, probably for real cause(s).

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1825869 - Make mail/test/browser/openpgp/browser_viewMessageSecurity.js work in Supernova. r=kaie

This has two problems:

• The S/MIME message created was not one that could be decrypted, so there was no (no longer any) security panel at all.
  For such a message the error message takes up all the message area (headers + body). Used a good s/mime message instead,
  since it was only testing the Ctrl+Alt+S shortcut to open the security details - content irrelevant.
• Needed to listen for keypress from the right document. Otherwise it would only work when the message was in focus.

Comment 4

[Kai Engert (:KaiE:)]

I'm counting 3 tests being reenabled in these 2 patches.
2 tests are still TODO, so I'm setting the leave-open flag.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6c305829682b
Reenable tests for OpenPGP functionality that is actually not broken. r=kaie.
https://hg.mozilla.org/comm-central/rev/151afdf52dfb
Make mail/test/browser/openpgp/browser_viewMessageSecurity.js work in Supernova. r=kaie

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: Bug 1825869 - Follow-up - prevent memleak. r=darktrojan

comm/mail/base/test/browser/browser_detachedWindows.js was failing

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7d2b64784b3c
Follow-up - prevent memleak. r=kaie DONTBUILD

Comment 8

[Wayne Mery (:wsmwk)]

I'm guessing we'd want the remaining work to be P1. Please adjust if that is incorrect.

Comment 9

[Magnus Melin [:mkmelin]]

The only remaining one is https://searchfox.org/comm-central/rev/db0b2ede820826536a7db026e808e884a5ebd03b/mail/test/browser/openpgp/browser_viewMessage.js#286 - bug 1837247

Comment 10

[Kenny Bacon]

Attachment: same problem

Thanks from ventklospectio1977.