1803255 - Fix and enable the remaining tests with the new 3-pane

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, task)

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix and enable the tests in mail/base/test/webextensions. r=aleca

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix and enable tests of the WebExtension menus API. r=aleca

Comment 3

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/c1d3b1f61519335ca8760006fb86fc9af5074c15
https://hg.mozilla.org/projects/ash/rev/bb6bd94a3fd2314266f161a51336b04ac3c4f10d

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix and enable tests for OpenPGP and S/MIME. r=aleca

Depends on D164011

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix progress notifications for WebExtensions. r=aleca

This changes browser_ext_tabs_events.js to stop expecting page load events when switching tabs.
It also fixes the case where about:message loads after tabmail.openTab returns, or where it's in a standalone message window.

Depends on D164169

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix and enable tests for messageDisplayAction API. r=aleca

Depends on D164170

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix and enable tests for the mailTabs API. r=aleca

Depends on D164171

Comment 8

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/c3a42d3207784ca2e0c6f3c596719ac43e2467f5

Comment 9

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/0119e979fc59e8626f0fc7dcf710fac6e11b85fa
https://hg.mozilla.org/projects/ash/rev/1915d49375e656656d476257d199ca548b8e1fce
https://hg.mozilla.org/projects/ash/rev/4741169c33b334918916f5559eb9fc78f0b22059

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix new extensions tests added on comm-central. r=aleca

These tests are mostly duplicates of existing tests, so if the changes look familiar it's because I've just fixed the same thing a second time!

Comment 11

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/2e3c4c1b9995a812dd4eccd8d4a0c205492b6dce

Comment 12

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Add a property to about:3pane/message to easily access the current tab. r=aleca

This will make things a lot easier for several WebExtension APIs.

In that code tabs are represented by tabmail tabInfo objects, or if not in the main window, by the window itself. This code provides direct access to those objects.

Comment 13

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Enable the working parts of browser_ext_commands_onCommand.js. r=aleca

The non-working part will be handled in another bug.

Depends on D165242

Comment 14

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix and enable the tests for the messageDisplay API. r=aleca

Depends on D165243

Comment 15

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix and enable browser_ext_tabs_content.js. r=aleca

Depends on D165244

Comment 16

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/3a5ddda20a083a742b66e06abbe44d4b666e684e
https://hg.mozilla.org/projects/ash/rev/d0df3c57b10cc4495e6e9b377eec9af8a4e6f3aa
https://hg.mozilla.org/projects/ash/rev/918c8e2d9631be5d014198a0c8310b9347cf94f2
https://hg.mozilla.org/projects/ash/rev/a6af3974dc9b8b9bb27cde6a34ea49ec348e445b

Comment 17

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix and enable the tabmail tests. r=aleca

Comment 18

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/b0bf3085da086ae1890f2f27c0a8ba86d5ac71d4

Comment 19

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix broken test browser_attachMenu.js. r=aleca

This test is broken on Windows with new mail tabs for reasons I don't understand. Rewriting some parts using existing utility functions fixes it somehow.

Comment 20

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix broken test browser_spacesToolbar.js. r=aleca

These tests all pointlessly attempt to remove files when cleaning up. browser_mailTabsAndWindows.js fails to do so on Windows and breaks browser_spacesToolbar.js.

Depends on D166513

Comment 21

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix broken test browser_generalContentPolicy.js. r=BenC

The code was emitting remote content notifications using the BrowsingContext of the remote content, but only checking the topmost BrowsingContext, so it didn't work when iframes got involved.

Comment 22

[Phabricator Automation]

Comment on attachment 9311707 [details]
Bug 1803255 - Fix broken test browser_generalContentPolicy.js. r=BenC

Revision D166517 was moved to bug 1799764. Setting attachment 9311707 [details] to obsolete.

Comment 23

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/60317e7fa3b2c1c5201d7edc4a77bd13bccef620
https://hg.mozilla.org/projects/ash/rev/5589ea5fb000f9aaa91a5414d688b49fc1008b1c

Comment 24

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix browser_mailTelemetry.js and browser_viewMessageSecurity.js. r=KaiE

This fixes the test with the new mail tabs, which don't count S/MIME messages as read if they can't be decrypted. It's been broken since bug 1805848.
The message body now matches that of mail/test/browser/smime/data/multipart-alternative.eml, where I think I got the original body too.

Comment 25

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix browser_perm_decrypt.js on Windows. r=aleca

This is failing on Windows trying to clean up a non-empty directory.

Comment 26

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix browser_viewMessage.js. r=freaktechnik

This just needed updating for the new mail tabs.

Comment 27

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1803255 - Fix browser_emlSubject.js on Mac OS. r=#thunderbird-reviewers

I never added the platform variation of the window title.

Comment 28

[Martin Giger [:freaktechnik]]

Pushed to ash:
https://hg.mozilla.org/projects/ash/rev/a7fcb76a3e682f734df123f030d2edb7789cc903
https://hg.mozilla.org/projects/ash/rev/0f49013327878de3761cae653c25074a8f5189ec

Comment 29

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/a1b695533b7fd7ef23aa722b4979b763d4924a8e
https://hg.mozilla.org/projects/ash/rev/aeb6445432378e9efd6d5f7316b5f5aac9d503c9

Comment 30

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/comm-central/rev/a1b695533b7fd7ef23aa722b4979b763d4924a8e
https://hg.mozilla.org/comm-central/rev/aeb6445432378e9efd6d5f7316b5f5aac9d503c9
https://hg.mozilla.org/comm-central/rev/0f49013327878de3761cae653c25074a8f5189ec
https://hg.mozilla.org/comm-central/rev/a7fcb76a3e682f734df123f030d2edb7789cc903
https://hg.mozilla.org/comm-central/rev/5589ea5fb000f9aaa91a5414d688b49fc1008b1c
https://hg.mozilla.org/comm-central/rev/60317e7fa3b2c1c5201d7edc4a77bd13bccef620
https://hg.mozilla.org/comm-central/rev/b0bf3085da086ae1890f2f27c0a8ba86d5ac71d4
https://hg.mozilla.org/comm-central/rev/a6af3974dc9b8b9bb27cde6a34ea49ec348e445b
https://hg.mozilla.org/comm-central/rev/918c8e2d9631be5d014198a0c8310b9347cf94f2
https://hg.mozilla.org/comm-central/rev/d0df3c57b10cc4495e6e9b377eec9af8a4e6f3aa
https://hg.mozilla.org/comm-central/rev/3a5ddda20a083a742b66e06abbe44d4b666e684e
https://hg.mozilla.org/comm-central/rev/2e3c4c1b9995a812dd4eccd8d4a0c205492b6dce
https://hg.mozilla.org/comm-central/rev/4741169c33b334918916f5559eb9fc78f0b22059
https://hg.mozilla.org/comm-central/rev/1915d49375e656656d476257d199ca548b8e1fce
https://hg.mozilla.org/comm-central/rev/0119e979fc59e8626f0fc7dcf710fac6e11b85fa
https://hg.mozilla.org/comm-central/rev/c3a42d3207784ca2e0c6f3c596719ac43e2467f5
https://hg.mozilla.org/comm-central/rev/bb6bd94a3fd2314266f161a51336b04ac3c4f10d
https://hg.mozilla.org/comm-central/rev/c1d3b1f61519335ca8760006fb86fc9af5074c15