Closed Bug 1833949 Opened 2 years ago Closed 2 years ago

Port bug 1826062: Upgrade Prettier to the latest version

Categories

(Thunderbird :: Upstream Synchronization, task)

task

Tracking

(thunderbird_esr102 wontfix)

RESOLVED FIXED
115 Branch
Tracking Status
thunderbird_esr102 --- wontfix

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(5 files)

When the prettier update hits mozilla-central on 2023-05-20, there will be some significant reformatting to do.

Will post two patches following the lead in bug 1826062, first is the update to prettier 2.0.5, then to prettier 2.8.8.

Assignee: nobody → rob

arrowParens now defaults to "always". Upstream is setting it to "avoid". This is
to keep calendar code from reformatting arrow functions.

Mostly spaces between "function" and the "()".

Depends on D178536

Attachment #9335002 - Attachment description: Bug 1833949 - Port bug 1826062: Prettier config changes for v2.0.5. r=#thunderbird-reviewers → Bug 1833949 - Port bug 1826062: Prettier config changes for v2.0.5. r=#thunderbird-reviewers,leftmostcat
Attachment #9335002 - Attachment description: Bug 1833949 - Port bug 1826062: Prettier config changes for v2.0.5. r=#thunderbird-reviewers,leftmostcat → Bug 1833949 - Port bug 1826062: Prettier config changes for v2.0.5. r=#thunderbird-reviewers

Prettier reformatting shifted the offending regex to its own line, necessitating
the the ignore comment be moved.

Depends on D178538

Status: NEW → ASSIGNED
Target Milestone: --- → 115 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/43ceb9ce6b09
Port bug 1826062: Prettier config changes for v2.0.5. r=leftmostcat
https://hg.mozilla.org/comm-central/rev/683c3fca7f85
Port bug 1826062: Automatic reformatting for Prettier 2.0.5. r=leftmostcat
https://hg.mozilla.org/comm-central/rev/9e8720653eb9
Port bug 1826062: Automatic reformatting for Prettier 2.8.8. r=mkmelin
https://hg.mozilla.org/comm-central/rev/6583f40d6b68
Manual fix after Prettier 2.8.8 update. r=clokep CLOSED TREE

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/bd61d0cd186c
Follow-up: Add reformatting revs to .hg-annotate-ignore-revs. r=aleca

Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: