1826633 - Newsgroup folders are now summarised when multiple messages or collapsed thread are selected

Status: RESOLVED WONTFIX

(Thunderbird :: Folder and Message Lists, defect)

Description

[MM]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36

Steps to reproduce:

News folders are now summarised when multiple messages are selected.

In 102 they weren't summarised. This was driven by:
https://searchfox.org/comm-central/rev/db7facd47e543927b303bb001fbfea8b0070de77/mail/base/content/folderDisplay.js#211
and
https://searchfox.org/comm-esr102/rev/6cb844cf1b3c1d290cbb297518e4cca1c131eb70/mail/base/content/messageDisplay.js#377-380

Looks like messageDisplay.js was removed from the code base and replaced by /about3Pane.js

Comment 1

[Thomas D. (:thomas8)]

I don't understand what this is about. Having proper STR, Actual & Expected result would help, maybe a sample URL and/or screenshot.

Comment 2

[MM]

Sorry about the poor report.
STR: Subscribe to a newsgroup. Select multiple messages. Result:
102: First selected message displayed (would be handy to select the last selected, see bug 364896)
113: Summary displayed, like for a normal mail folder.

IOW, the ability to disable summaries based in folder (type) was lost. See code references in comment #0.

Comment 3

[Magnus Melin [:mkmelin]]

It's a slight change in behavior. Not sure I'd call it a bug. Sure, for news you won't get very elaborate summaries shown but it's not like we have something better to show... (until bug 478167)

Comment 4

[MM]

This comment suggests that summarising makes no sense for "offline" newsgroups. The visual result also isn't ideal. It would be ideal to fix bug 364896 (has patch) until bug 478167 is implemented.

Besides, it's unclear whether setting pref mail.operate_on_msgs_in_collapsed_threads to false will work as intended now. summarizeSelectionInFolder() is still used:
https://searchfox.org/comm-central/search?q=summarizeSelectionInFolder&path=&case=false&regexp=false

Comment 5

[MM]

Some newsgroup discussions suggest that this aggravates bug 1824422 since too many articles are fetched.

Comment 6

[MM]

Further to that: Summarising also happens when a closed thread is selected.

Comment 7

[Fred Vanderstein]

Fixed as part of https://github.com/Betterbird/thunderbird-patches/blob/main/115/features/18-feature-multiselect-shows-current.patch.

Comment 8

[Magnus Melin [:mkmelin]]

With bug 545365 now fixed, I don't think nntp needs any special treatment anymore.