1826740 - Certain CFRs no longer point to the correct position when changing the orientation

Status: ASSIGNED

(Fenix :: Tabs, defect)

Description

[Delia Pop (Android QA)]

Attachment: Inactive Tabs CFR.mp4

Steps to reproduce

1. Launch Firefox for Android and open a few tabs.
2. Have one tab selected and send the application in background.
3. Go to device's settings and set the time to 14 days in the future.
4. Bring Firefox for Android foreground and access the Tabs Tray.
5. Once the Inactive Tabs CFR is displayed, change the orientation.
6. Observe the Inactive Tabs CFR.

Expected behavior

The Inactive Tabs CFR should still point to the inactive tabs section when the orientation is changed.

Actual behavior

The Inactive Tabs CFR no longer points to the inactive tabs section when changing the orientation is changed, regardless of the initial orientation.

Device information

• Firefox version: Nightly 113.0a1, Beta 112.0b9, RC 112.0
• Android device model: Lenovo Yoga Tab 11 (and any device)
• Android OS version: Android 11

Any additional information?

• This was previously reported in Github when Inactive Tabs had a different UI:
  https://github.com/mozilla-mobile/fenix/issues/21716
  https://github.com/mozilla-mobile/fenix/issues/22105

• A similar issue regarding to a different CFR changing position was discussed in https://bugzilla.mozilla.org/show_bug.cgi?id=1819949#c0.

Comment 1

[Joe M [:jmahon]]

Indexing in Bug 1818308 just so we don't lose track of this one.

Comment 2

[Vlad Dreghici [:vdreghici]]

I have looked into this issue a bit and noticed that inactive tabs CFR is actually an Android dialog. Since there have been already established a set of behaviors for all CFRs in the app, and we have started working on them, migrating private browsing recommendation CFR already to CFRPopup, I suppose it is safe to say that we could do the same with this CFR, in order to unify CFRs behaviors in the app.

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1826740 - Migrate Inactive Tabs Dialog to CFRPopup (#1698)

Comment 4

[Joe M [:jmahon]]

I'm combining this bug with https://bugzilla.mozilla.org/show_bug.cgi?id=1855951 for simplicity.

Two examples of orientation changes causing issues with CFRs:

• The shopping CFRs is not pointing to the shopping icon when turning in landscape mode
• The Inactive Tabs CFR no longer points to the inactive tabs section when changing the orientation

These should probably be fixed in the same PR.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:

• Bug 1855951: S3

:vdreghici, could you consider increasing the severity of this bug to S3?

For more information, please visit BugBot documentation.

Comment 7

[Vlad Dreghici [:vdreghici]]

Leaving S4 for now as it is a minor cosmetic issue