1827027 - If you resize small pop-up windows, hamburger menu icon can be made to overlap URLbar and not-be-clickable

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot of the fully-shrunk window with overlapping buttons

STR:

1. Visit https://www.sfcu.org/membership-rewards/
2. Click "Live Chat" link at top left (note that your browser has to be at least ~1000px wide for it to show up)
3. Resize the pop-up window that appears to be skinnier -- as skinny as you can make it.

ACTUAL RESULTS:
The hamburger button gets pushed "behind" the location bar, BUT its hamburger icon remains visible! It's still not clickable, though, even though it sorta looks like it would be. Any clicks are instead sent to the location-bar UI that it's overlapping.

[edited to remove the part about the extension-menu-button getting partially and then fully pushed behind the location bar -- that behavior has evolved a bit, per comment 2]

EXPECTED RESULTS:

• Buttons should not be pushed underneath other UI. They should be pushed off the edge of the UI and clipped, instead. (That's what used to happen before this regressed, at least.)
• Hamburger icon menu shouldn't be visible-and-yet-unclickable.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a4a8521b307275498ecda987249e72150c3c110d&tochange=0645b630915e38a3a37d076aa7f431a72387699e

In that range, bug 1795260 looks like it would've been what regressed this.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug with Nightly 2023-03-01

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)

ACTUAL RESULTS:
(A) As it shrinks, the extension-menu-button gets partially and then fully pushed behind the location bar.

Actually -- in current Nightly (2023-04-07), the extension menu button stays in place (hooray!) but the hamburger menu overlaps it even with the initial size of the window (darn) and still gets pushed underneath/beyond it.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug with Nightly 2023-04-07

Comment 4

[BugBot [:suhaib / :marco]]

:emilio, since you are the author of the regressor, bug 1795260, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 5

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #2)

Actually -- in current Nightly (2023-04-07), the extension menu button stays in place (hooray!)

[answering my own curiosity: mozregression says that this improvement came from Bug 1820743 ]

but the hamburger menu overlaps it even with the initial size of the window (darn) and still gets pushed underneath/beyond it.

I spun off bug 1827031 on this observation.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1827027 - Allow urlbar to shrink more for popups. r=dao

I'm not convinced this is the right fix but we're fundamentally out of
space otherwise...

Comment 7

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1795260

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2e62b94c7cd
Allow urlbar to shrink more for popups. r=dao

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e2e62b94c7cd

Comment 10

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Comment 11

[Suhaib Mujahid [:suhaib]]

Attachment: Screenshot 2023-04-13 at 3.01.10 PM.png

Comment 12

[Suhaib Mujahid [:suhaib]]

The issue doesn't happen for 112 on the release channel.

Comment 13

[Daniel Holbert [:dholbert]]

(In reply to Suhaib Mujahid [:suhaib] from comment #12)

The issue doesn't happen for 112 on the release channel.

Yes it does, for me at least. (I tested 112 as well as 111 release and both were affected. I imagine release versions are affected as far back as 108 given the regressor bug 1795260.)

Note that this bug is specific to popup windows (e.g. the one launched from the "live chat" link on https://www.sfcu.org/membership-rewards/ ), and your screenshot doesn't seem to show a popup window -- the firefox window shown there has a bookmarks toolbar, and back/forward/reload icons, which indicate that it's a regular window rather than a popup.

But in any case: wontfix for 112 seems reasonable.

Comment 14

[Daniel Holbert [:dholbert]]

Attachment: screenshot in Nightly 2023-04-13

Here's a screenshot in current Nightly, where I've shrunk the popup to be as skinny as possible. There's no space to show much of the URL, of course, which is to-be-expected given the shrinkage. But the buttons are all visible, non-overlapping, and functional. Hooray!

Comment 15

[Daniel Holbert [:dholbert]]

Marking as verified-fixed for v114 Nightly, per comment 14.

Comment 16

[Suhaib Mujahid [:suhaib]]

(In reply to Daniel Holbert [:dholbert] from comment #13)

Yes it does, for me at least. (I tested 112 as well as 111 release and both were affected. I imagine release versions are affected as far back as 108 given the regressor bug 1795260.)

Sorry, you are right. I can repreduce it on 112 release with a popup window. But not the regular window.

Note that this bug is specific to popup windows (e.g. the one launched from the "live chat" link on https://www.sfcu.org/membership-rewards/ ), and your screenshot doesn't seem to show a popup window -- the firefox window shown there has a bookmarks toolbar, and back/forward/reload icons, which indicate that it's a regular window rather than a popup.

I was able to reproduce this on 113, even on the regular window.

Comment 17

[Suhaib Mujahid [:suhaib]]

Attachment: Screenshot 2023-04-12 at 12.45.23 PM.png

Here is a screenshot where the issues happen on 113 regular window.

Comment 18

[Daniel Holbert [:dholbert]]

Thanks for clarifying. I can reproduce that issue as well, and I can confirm that issue is fixed in current Nightly. I used mozregression --find-fix to find when that was fixed, and it seems it was bug 1827031 that fixed that regular-window-problem, rather than the patch for this bug here.

So: the hamburger/extension overlap in comment 17 is a version of bug 1827031, not this bug here.