1827882 - Longer attachment name fails to text-overflow with ellipsis, pushes other UI elements out of view (Save button, attachment file size etc.)

Status: RESOLVED WORKSFORME

(Thunderbird :: Message Reader UI, defect, P2)

Description

[Jaise]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/112.0

Steps to reproduce:

mailed received with long length attachment name[higher than attachment row or resize message reader to small size] hide file size in daily branch.

Actual results:

hide file size in daily branch.

Expected results:

should not hide filesize.

Comment 1

[Thomas D. (:thomas8)]

Jaise, are you able to provide a screenshot with private data blacked out? Via Attach New File button above comment 0

Comment 2

[Thomas D. (:thomas8)]

Attachment: Screenshot 1:

Confirming for Daily 114.0a1 (2023-04-17) (64-bit), Win10.

Worse, this will hide the Save button on attachment pane header bar for single attachment with long name. Which makes for very poor UX in a frequently used part of the app.

Looks like another flexbox fallout? See Bug 1826881

Comment 3

[Wayne Mery (:wsmwk)]

Easy to solve?

Comment 4

[Richard Marti (:Paenglab)]

The width of the attachmentItem is set somewhere by JS. When I set a smaller width through Inspector it shrinks correctly.

This needs to be fixed by someone that knows JS better than me.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: Bug 1827882 - Make longer attachment names not push other UI elements out of view. r=Paenglab

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: bug1827882-long-attachment-name.eml

Elizabeth, can you take a look with the patch applied.
Seems to be work correctly for me, but apparently not for Richard.

Comment 8

[Elizabeth Mitchell]

(In reply to Magnus Melin [:mkmelin] from comment #7)

Created attachment 9336030 [details]
bug1827882-long-attachment-name.eml

Elizabeth, can you take a look with the patch applied.
Seems to be work correctly for me, but apparently not for Richard.

I'll look at it.

Comment 9

[Magnus Melin [:mkmelin]]

Someone else will have to check this. I can't reproduce the issue reported with the patch.

Comment 11

[Tom Adler]

Attachment: Truncated text

This issue makes the feed reader unusable to me, because half of the entry text is truncated, so please reconsider the severity change

Comment 12

[Tom Adler]

I can reproduce this bug on Linux by subscribing to this RSS feed https://meduza.io/rss/all and attempting to read its entries in three-panel-view on not-too-wide screen.

Comment 13

[Magnus Melin [:mkmelin]]

Tom, I don't think that's this bug. (If a bug at all, if you have that narrow screen vertical view isn't that usable.)

Comment 14

[Magnus Melin [:mkmelin]]

Actually, the original bug seems gone as well.