1828430 - Links in devtools UI lack underline / rely on use of color only

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[Marc Seibert (:mseibert)]

We're adding underlines back to links in the Firefox UI for reasons mentioned in the bug below. Please evaluate if this is applicable to devtools as well. Missing underlines can be found in "about:debugging".

+++ This bug was initially created as a clone of Bug #1821788 +++

We're setting text-decoration: none on the .text-link classes in common-shared.css and browser-shared.css. common-shared.css is also applying this rule to html|a. activity-stream.css is doing the same thing under their link rules.

By setting this rule we're failing WCAG Success Criterion 1.4.1 Use of Color. The underline is applied to links so they can be easily identified, specially for folks who cannot perceive color differences. See Failure of Success Criterion 1.4.1. Ideally, we should remove that rule from our links.

Comment 1

[Julian Descottes [:jdescottes]]

Thanks for filing Marc, do you have any idea about the timeline to fix this? It would help us to set the priority, thanks!

Comment 2

[Dão Gottwald [:dao]]

(In reply to Julian Descottes [:jdescottes] from comment #1)

Thanks for filing Marc, do you have any idea about the timeline to fix this? It would help us to set the priority, thanks!

Bug 1821788 targets Firefox 114, so it might be a good idea to do the same here, but there's no strict dependency. Perhaps worth pointing out: accessibility folks marked bug 1821788 as [access-s2], so they considered it a significant issue worth fixing soon.

Comment 3

[Julian Descottes [:jdescottes]]

Ok thanks. Not sure about updating all of that for 114, but I think we should split this between about:debugging and the rest of devtools.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, [access-s2].
:Honza, could you consider increasing the severity?

For more information, please visit auto_nag documentation.

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1828430 - [devtools] Use underline for devtools links opening pages in tabs or windows

Depends on D175924

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1828430 - [devtools] Add underline to links in the inspector

Depends on D175925

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1828430 - [devtools] Add underline to internal links in console and netmonitor

Depends on D175926

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1828430 - [devtools] Remove unused devtools-source-link css class

Depends on D175927

I think this class is unused, at least I could not find any clear consumer in the codebase

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa45bba3f2e3
[devtools] Use underline for devtools links opening pages in tabs or windows r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/7009f7e09ee8
[devtools] Add underline to links in the inspector r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/55c92609904d
[devtools] Add underline to internal links in console and netmonitor r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/4ce470da5901
[devtools] Remove unused devtools-source-link css class r=devtools-reviewers,bomsy

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fa45bba3f2e3
https://hg.mozilla.org/mozilla-central/rev/7009f7e09ee8
https://hg.mozilla.org/mozilla-central/rev/55c92609904d
https://hg.mozilla.org/mozilla-central/rev/4ce470da5901