1828508 - Clean up Firefox View Feature Tour + Notification

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Vtay]

The Firefox View wants to disable the tour for Firefox view + panel notification.

The rational was that when we first introduce Firefox View, most of the time there won’t be much content in there especially if it’s a fresh install so there isn’t much value in this surface at the start. Also, the messaging in the tour is very similar to the messaging in the empty states so it feels a bit repetitive that we are saying the same thing twice.

They think a new strategy for how we introduce Firefox View is needed. It could be more contextual and we trigger feature tours if a user performs an action that we think would benefit them if we show them View at that moment as an example.

Comment 1

[Punam Dahiya [:pdahiya]]

Scope of the work will involve disabling messages and update tests. Thanks

Comment 2

[Shane Hughes [:aminomancer]]

I will disable these messages as part of bug 1821826 in order to simplify the process of uplifting that to 116. We want to get rid of them along with bug 1821826 because it will drastically reduce the risk of uplift there.

I'll leave them around (disabled) to make that patch simpler but they can then be removed here.

Comment 3

[Hanna Alemu [:hanna_a]]

Are there plans to show these callouts on about:firefoxview in the future? If not, should this cleanup also remove featureCalloutCheck (which is not a real trigger but only being used on about:firefoxview) and code associated with it, and the browser.firefox-view.feature-tour pref?

Comment 4

[Punam Dahiya [:pdahiya]]

From the bug original description , desire is to disable featurecallout tour and related Spotlight and CFR messages created to promote about:firefoxview

https://www.figma.com/file/mrjF8OroTxjSZglHUjRybQ/Callout-(Feature%2FProduct-tour)?type=design&node-id=89-2686&mode=design&t=NARqo5vkv6G8p312-0

Double checking with @vtay if there isn't immediate need to promote and onboard firefoxview and safe to remove from code Firefox view tour flow, Firefox view spotlight and Firefox view CFR related messages, assets and strings. Thanks!

https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/FeatureCalloutMessages.sys.mjs
https://searchfox.org/mozilla-central/rev/c130c69b7b863d5e28ab9524b65c27c7a9507c48/browser/locales/en-US/browser/newtab/asrouter.ftl#174

Comment 5

[Shane Hughes [:aminomancer]]

(In reply to Punam Dahiya [:pdahiya] from comment #4)

From the bug original description , desire is to disable featurecallout tour and related Spotlight and CFR messages created to promote about:firefoxview

https://www.figma.com/file/mrjF8OroTxjSZglHUjRybQ/Callout-(Feature%2FProduct-tour)?type=design&node-id=89-2686&mode=design&t=NARqo5vkv6G8p312-0

Double checking with @vtay if there isn't immediate need to promote and onboard firefoxview and safe to remove from code Firefox view tour flow, Firefox view spotlight and Firefox view CFR related messages, assets and strings. Thanks!

https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/FeatureCalloutMessages.sys.mjs
https://searchfox.org/mozilla-central/rev/c130c69b7b863d5e28ab9524b65c27c7a9507c48/browser/locales/en-US/browser/newtab/asrouter.ftl#174

The feature tour and its spotlight are currently disabled, as their trigger is no longer fired anywhere, and the CFR was removed a while ago. What remains is to fully remove the feature tour messages and pref, and to migrate the tests.

The feature callout surface's primary test coverage is handled in the firefoxview feature callout tests. These are currently disabled, because the old Fx View implementation was removed. We'd like to re-enable those tests but refactor them to work in the browser chrome, and move them out of the firefoxview directory and into the aboutwelcome or asrouter directory.

(In reply to hanna A from comment #3)

Are there plans to show these callouts on about:firefoxview in the future? If not, should this cleanup also remove featureCalloutCheck (which is not a real trigger but only being used on about:firefoxview) and code associated with it, and the browser.firefox-view.feature-tour pref?

I'd prefer we not remove featureCalloutCheck as just part of a general cleanup, as the feature callout logic is pretty complicated and easy to regress. The logic should be its own bug, IMO. This bug is already pretty big - the testing stuff could be handled in this bug or elsewhere, but I think changes to FeatureCallout.sys.mjs should be spun off into a separate bug.

Comment 6

[Hanna Alemu [:hanna_a]]

Attachment: WIP: Bug 1828508 - Clean up Firefox View Feature Tour + Notification

Comment 7

[Vtay]

Yes - i can confirm

Comment 8

[Hanna Alemu [:hanna_a]]

Attachment: Bug 1828508 - Clean up Firefox View Feature Tour + Notification

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ad93652861a
Clean up Firefox View Feature Tour + Notification r=omc-reviewers,fluent-reviewers,fxview-reviewers,nsharpley,bolsson,aminomancer

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5ad93652861a