1828997 - Crash in [@ mozilla::dom::syncedcontext::Transaction<T>::Commit | mozilla::dom::BrowsingContext::SetAllowJavascript ] with MOZ_CRASH Reason: CanSet failed for field(s): AllowJavascript

Status: REOPENED

(Thunderbird :: General, defect)

Description

[Worcester12345]

Crash report: https://crash-stats.mozilla.org/report/index/5c42de3c-fba8-4cbf-87cb-1ba3c0230419

MOZ_CRASH Reason: CanSet failed for field(s): AllowJavascript

Top 10 frames of crashing thread:

0  xul.dll  mozilla::dom::syncedcontext::Transaction<mozilla::dom::BrowsingContext>::Commit  docshell/base/SyncedContextInlines.h:103
1  xul.dll  mozilla::dom::BrowsingContext::SetAllowJavascript  docshell/base/BrowsingContext.h:256
2  xul.dll  nsMsgContentPolicy::SetDisableItemsOnMailNewsUrlDocshells  mailnews/base/src/nsMsgContentPolicy.cpp:853
3  xul.dll  nsMsgContentPolicy::ShouldLoad  mailnews/base/src/nsMsgContentPolicy.cpp:200
4  xul.dll  nsContentPolicy::CheckPolicy  dom/base/nsContentPolicy.cpp:119
5  xul.dll  nsContentPolicy::ShouldLoad  dom/base/nsContentPolicy.cpp:158
6  xul.dll  NS_CheckContentLoadPolicy  dom/base/nsContentPolicyUtils.h:239
7  xul.dll  nsDocShell::PerformRetargeting  docshell/base/nsDocShell.cpp:8568
8  xul.dll  nsDocShell::InternalLoad  docshell/base/nsDocShell.cpp:9345
9  xul.dll  nsDocShell::OnLinkClickSync  docshell/base/nsDocShell.cpp:13133

Comment 1

[Wayne Mery (:wsmwk)]

Less than 2% of crashes are thunderbird.

Comment 2

[Andrew McCreight [:mccr8]]

The Thunderbird crashes are mostly on "CanSet failed for field(s): AllowJavascript" which is probably a different issue.

Comment 3

[Wayne Mery (:wsmwk)]

Thanks Andrew.

Comment 4

[Magnus Melin [:mkmelin]]

It's certainly coming from us setting browsingContext->SetAllowJavascript(false), but I don't know why that crashes

Comment 5

[Wayne Mery (:wsmwk)]

(In reply to Andrew McCreight [:mccr8] from comment #2)

The Thunderbird crashes are mostly on "CanSet failed for field(s): AllowJavascript" which is probably a different issue.

Over 97% have that reason. From this query there are two others

• CanSet failed for field(s): MessageManagerGroup bp-ce72bed7-258c-4db2-b87d-f99620230413
• CanSet failed for field(s): CurrentInnerWindowId bp-4701118f-0372-471f-a7fb-d938e0230420

Comment 6

[Andrew McCreight [:mccr8]]

Thanks to bug 1834536, the signature for this crash has changed. The crashes in comment 5 will also show up separately now, if you want to file bugs for those.

Comment 7

[Wayne Mery (:wsmwk)]

60% of crashes have uptime <60 seconds. Of that, about 1/3 is uptime <20 seconds

Comment 9

[Worcester12345]

Not sure if it matters at all, but some recent Java updates have come out.

Comment 10

[Wayne Mery (:wsmwk)]

For the last 6 months crash rate is flat, and no user comments in crash reports.

(In reply to Wayne Mery (:wsmwk) from comment #5)

• CanSet failed for field(s): MessageManagerGroup bp-ce72bed7-258c-4db2-b87d-f99620230413
• CanSet failed for field(s): CurrentInnerWindowId bp-4701118f-0372-471f-a7fb-d938e0230420

I'm not finding crashes with any of these reasons.