Links in the OAuth authentication window don't open when clicked on
Categories
(Thunderbird :: General, defect)
Tracking
(thunderbird_esr128 affected)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr128 | --- | affected |
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(1 file)
To see this start signing in to a Google account and when the authentication dialog pops up, click on one of the links, e.g. privacy policy. Nothing happens except errors logged in the console.
It looks like we need to set up browserDOMWindow like we do in extensionPopup.js so that the browser element knows where to open a new tab with the link. Just copying that one works, but we should take a closer look to see if all of the code is appropriate, and also a test should be made.
|
Assignee | |
Comment 1•23 days ago
|
||
This adds the code to go back to the main window and open a tab. It won't work if the OAuth window
is private (not the default) as in that case we'd need a main window with private browsing enabled,
which we don't do.
|
||
Updated•23 days ago
|
|
||
Comment 2•21 days ago
|
||
If this doesn't go back to at least 128, please adjust the version.
|
|
Assignee | |
Updated•21 days ago
|
|
|
Assignee | |
Comment 3•21 days ago
|
||
It seems there's a different problem on 128. :/
|
|
Assignee | |
Comment 4•21 days ago
|
||
Bug 1828997 is the problem I was hitting on 128. We'll need to fix that too.
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/b06a93061f79
Fix links with target="_blank" in OAuth authentication window. r=mkmelin
Description
•