1829340 - undo archive via ctrl-z does not unarchive expected message

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[Meichthys]

Steps to reproduce:

This was supposedly fixed in Bug 1823748 , but there seems to be a regression in v113.

STR:

• Open Thunderbird and navigate to inbox
• use the a shortcut to archive a few emails
• use the ctrl-z shortcut twice to unarchive the emails

Actual results:

The emails are not unarchived

Expected results:

The emails should be moved back to the inbox in the reverse order of how they were archived:

Shortcut timeline:

• a = message 1 archived
• a = message 2 archived
• ctrl-z = message 2 unarchived
• ctrl-z = message 1 unarchived

Comment 1

[Meichthys]

Just updating to report that this is still an issue in v113.0b6

Comment 2

[Wayne Mery (:wsmwk)]

Meichthys, does this still reproduce wth 115.0b3?

Comment 3

[Meichthys]

Hi Wayne, Yes it does still reproduce on v115.0b3 👍

Comment 4

[Mitra Ardron]

I can confirm that I've seen behavior like this.

The pattern of use here, which I suspect I share with others, is to go through my email hitting Del & J on messages till I get to something I read and then usually hit A on, and as others also point out sometimes the fingers are a bit quick and a Command-Z is needed to get one or more back.

I've tried, but failed, to reliably reproduce it when I do things slowly, so there may be a timing issue, for sure I've seen the wrong message reinserted into the listing, and had had to dig into the Archives and Trash and sure enough found messages there.

Given the other problems with message listing - wrong messages, wrong headers etc, its hard to actually separate what is the Undo not working, and what is A/Del/J being used on a wrong message - i.e. does it apply to the message shown in the list, or the one whose text is displayed below?

Hope this is helpful in tracking it down.

Comment 5

[Meichthys]

My pattern of usage is to archive everything (zero inbox method). I use the a key repeatedly as i archive mail in my inbox, but often want to undo the archive to read an email more fully. When i try to ctrl-z to undo it usually does nothing, but i have seen times when it will undo a much older message.

Comment 6

[Wayne Mery (:wsmwk)]

Steve, can you reproduce?

Comment 7

[Steve Edmonds]

I can advise that in 116.0b1 undo from the edit menu does not undo a message delete (message move to bin).
I also confirm that in 116.0b1 this original bug is still present.

Comment 8

[Brendan Abolivier [:babolivier]]

Attachment: Bug 1829340 - Keep a reference to the transaction manager when archiving a message. r=#thunderbird-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b8c2ae757640
Keep a reference to the transaction manager when archiving a message. r=leftmostcat

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1829340 follow-up - Prevent bad interaction between tests. r=#thunderbird-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/10362909d481
follow-up - Prevent bad interaction between tests. r=#thunderbird-reviewers

Comment 12

[Brendan Abolivier [:babolivier]]

Comment on attachment 9344436 [details]
Bug 1829340 - Keep a reference to the transaction manager when archiving a message. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): Bug 1744657
User impact if declined: Users cannot undo after archiving
Testing completed (on c-c, etc.): On c-c
Risk to taking this patch (and alternatives if risky): The functional change itself is low-risk as it is small and covered by a test. This patch must be pushed together with the patch in attachment 9345979 [details], to avoid introducing undesirable side-effects in other tests.

Comment 13

[Brendan Abolivier [:babolivier]]

Comment on attachment 9345979 [details]
Bug 1829340 follow-up - Prevent bad interaction between tests. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): Follow-up patch to fix side effects in tests introduced by the patch in attachment 9344436 [details].
User impact if declined: No user impact.
Testing completed (on c-c, etc.): On c-c
Risk to taking this patch (and alternatives if risky): There shouldn't be any, as this patch fixes the setup for a new test introduced in attachment 9344436 [details].

Comment 14

[Wayne Mery (:wsmwk)]

Didn't make last beta

Comment 17

[Wayne Mery (:wsmwk)]

This works for me with 117 beta

Comment 18

[Wayne Mery (:wsmwk)]

Comment on attachment 9344436 [details]
Bug 1829340 - Keep a reference to the transaction manager when archiving a message. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 19

[Wayne Mery (:wsmwk)]

Comment on attachment 9345979 [details]
Bug 1829340 follow-up - Prevent bad interaction between tests. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 20

[Rob Lemley [:rjl]]

Thunderbird 115.1.1:
https://hg.mozilla.org/releases/comm-esr115/rev/c1c30b05e63b
https://hg.mozilla.org/releases/comm-esr115/rev/af7fd2b1a440