1830036 - rlbox.wasm.c:12:10: fatal error: 'alloca.h' file not found on OpenBSD

Status: RESOLVED FIXED

(Core :: Security: RLBox, defect)

Description

[Landry Breuil (:gaston)]

similar to bug #1829268, building m-c fails now on OpenBSD, where there's no alloca.h:

36:16.27 In file included from rlbox.wasm.c:16:
36:16.27 /build/obj/buildslave/mozilla-central/dist/system_wrappers/alloca.h:3:15: fatal error: 'alloca.h' file not found
36:16.27 #include_next <alloca.h>
36:16.27               ^~~~~~~~~~

cf http://buildbot.rhaalovely.net/nine/#/builders/3/builds/1673/steps/8/logs/stdio

i dunno what the process is to update the generated (?) files but OpenBSD probably needs the same treatment as FreeBSD that was done in https://phabricator.services.mozilla.com/D176254 inside third_party/wasm2c/src/prebuilt/wasm2c_source_includes.cc

Comment 1

[Landry Breuil (:gaston)]

wip local patch that seems to help, build still running:

--- a/third_party/wasm2c/src/prebuilt/wasm2c_source_includes.cc
+++ b/third_party/wasm2c/src/prebuilt/wasm2c_source_includes.cc
@@ -15,17 +15,17 @@ R"w2c_template(#include <malloc.h>
 R"w2c_template(#elif defined(_MSC_VER)
 )w2c_template"
 R"w2c_template(#include <intrin.h>
 )w2c_template"
 R"w2c_template(#include <malloc.h>
 )w2c_template"
 R"w2c_template(#define alloca _alloca
 )w2c_template"
-R"w2c_template(#elif defined(__FreeBSD__)
+R"w2c_template(#elif defined(__FreeBSD__) || defined(__OpenBSD__)
 )w2c_template"
 R"w2c_template(#include <stdlib.h>
 )w2c_template"
 R"w2c_template(#else
 )w2c_template"
 R"w2c_template(#include <alloca.h>
 )w2c_template"
 R"w2c_template(#endif

Comment 2

[Landry Breuil (:gaston)]

filed https://github.com/WebAssembly/wabt/issues/2216 upstream

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1827704

:shravanrn, since you are the author of the regressor, bug 1827704, could you take a look?

For more information, please visit auto_nag documentation.

Comment 4

[Shravan Narayan]

Attachment: Bug 1830036 - Update wasm2c compiler used with RLBox to support OpenBSD r=glandium

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9b1472332b2
Update wasm2c compiler used with RLBox to support OpenBSD r=glandium

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d9b1472332b2