1830385 - Implement the dismissal "Thanks for your feedback" message in Suggest results

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1830385 - Implement the dismissal "Thanks for your feedback" message in Suggest results.

This implements the second "thanks for your feedback" UI for weather, Pocket,
addon, MDN, etc. suggestions. The first UI is in D175729, which this revision
builds on.

This UI is shown when a result is dismissed. It's essentially a tip with a
smaller icon and padding. It has the "Got it" button that dismisses the tip
itself when clicked.

I noticed tip top and bottom borders use --panel-separator-color, which
doesn't seem right. They're supposed to be the same color as the borders between
the input and view and between the results and one-off buttons, which is
--autocomplete-popup-separator-color. The spec for this feature uses the same
colors too. So I changed that too. (The use of --panel-separator-color goes
back to the initial tip implementation in 70, but search tips and
interventions weren't added until 74, in bug 1606909 and bug 1606917. I checked,
and in 74 all the borders are the same color.)

References:

• Figma (see "A11y review - user feedback" in sidebar)
• Clickable prototype (see "Revised 4/3" in sidebar)
• Content design

Depends on D175729

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d09e87ed0a41
Implement the dismissal "Thanks for your feedback" message in Suggest results. r=dao,fluent-reviewers,flod

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing xpcshell failures on test_weather.js

Backout link

Push with failures

Failure log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/affe7591f954
Implement the dismissal "Thanks for your feedback" message in Suggest results. r=dao,fluent-reviewers,flod

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/affe7591f954

Comment 6

[Drew Willcoxon :adw]

Attachment: screenshot

STR for QA:

1. Enable weather suggestions
2. Trigger a suggestion
3. Click the Feedback menu > Don't show this > either menu item
4. Verify a "Thanks for your feedback" message replaces the suggestion, see screenshot
5. Click the "Got it" button and verify the message goes away

If you need to undo it, set browser.urlbar.suggest.weather back to true.

Comment 7

[Carmen Fat [:cfat] - Ecosystem QA]

We have verified this issue on the latest Firefox Nightly 115.0a1 (Build ID: 20230508214159) and Beta 114.0b1 (Build ID: 20230508175934), on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

• Clicking any of the “Don’t show this” sub-menu options (“Not relevant”, “Not interested”) will remove the weather result.
• Once the weather result is removed, the “Thanks for your feedback. You won’t see this again.” message is displayed, with the “Got it” button on the right side of the panel.
• Clicking the “Got it” button will dismiss the “Thanks for your feedback. You won’t see this again.” message from the panel.

While testing the Feedback menu options, we encountered a new issue which we filed under Bug 1832105.