1830755 - space bar no longer does a page down in RSS - for feed messages showing as webpage.

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect, P2)

Description

[Daniel Descheneaux]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/112.0

Steps to reproduce:

In normal email, with a message focused, pressing space bar moves the message one page down. In RSS feeds, space bar does nothing.

Actual results:

I upgraded from 52.9.1 to 102.10.1 and the bug appeared. Pressing the space bar does not move the RSS message one screen down.

Expected results:

The RSS message should scroll down just like an email. Same behavior on a Linux or Windows install, by the way.

Comment 1

[Magnus Melin [:mkmelin]]

That works for me. Tried Help | Troubleshoot mode?

Comment 2

[Daniel Descheneaux]

Yep, spaceber still does nothing. In which rss feed does it work for you? I'll try it here.

Comment 3

[Daniel Descheneaux]

Ah, let me add some precision : once I have clicked in the message, spacebar does page down - which is not necessary in emails.

Comment 4

[Daniel Descheneaux]

So? Is the existence of the bug I report confirmed?

Comment 5

[Magnus Melin [:mkmelin]]

Right, not working on Daily either.
https://searchfox.org/comm-central/rev/767fe445f4a0f23d339777bddec046ea5cfa4c09/mail/base/content/mailCommon.js#362,365,370 contentWindow is null when for feed messages showing as webpage.

Comment 6

[Wayne Mery (:wsmwk)]

I have seen this reported on reddit as being a new issue for 115.0. Somewhere along the line this has gotten worse as Magnus indicates.

With beta 116 space bar certainly mostly does not work for me. (but not 100%)
With today's daily it WORKS 100% with feed https://connect.mozilla.org/bnzry48543/rss/board?board.id=discussions

If it is now working in nightly, we will want find what fixed it and apply it to 115. I'm not finding a bug report that fixed it in https://mzl.la/3pSKe00

Comment 7

[Wayne Mery (:wsmwk)]

Magnus is this still failing for you on daily?

Comment 8

[Magnus Melin [:mkmelin]]

Yes still failing on Daily. It works in one clicks in the message first. Otherwise, it doesn't.

Comment 9

[Thilo [:ThiloteE]]

I am not sure why I was tagged here. Although, I do have beta and daily installed, but I would not know how to find the regression window, as I do not know how to compile Thunderbird and cannot move back to older dailies and older betas.

Comment 10

[Wayne Mery (:wsmwk)]

Hartmut,
Are you thinking this has the same regression windows as bug 1468925?

Comment 11

[Alessandro Castellani [:aleca]]

This works for me on both daily and 115.
Make sure the message is focused (click on the message body) before pressing the spacebar.

Comment 12

[Hartmut Welpmann [:welpy-cw]]

(In reply to Wayne Mery (:wsmwk) from comment #10)

Hartmut,
Are you thinking this has the same regression windows as bug 1468925?

While bug 1468925 may have originally had a different cause (which might have been fixed in the meantime), the behaviour discussed from bug 1468925 comment 24 onwards seems to have its origins in the switch to E10s. So I think this is exactly the same bug, as I find that the somewhat erratic behaviour in feed messages matches that of other messages. (Clicking into the message pane can enable or disable (!) scrolling with the spacebar, moving the mouse somewhere else for a while and back can do the same).

Comment 13

[Wayne Mery (:wsmwk)]

(In reply to Alessandro Castellani [:aleca] from comment #11)

This works for me on both daily and 115.
Make sure the message is focused (click on the message body) before pressing the spacebar.

That's the extra step I want not to have to do. Non-RSS messages do not require clicking on the message body.

(In reply to Hartmut Welpmann [:welpy-cw] from comment #12)

Clicking into the message pane can enable or disable (!) scrolling with the spacebar, moving the mouse somewhere else for a while and back can do the same.

Moving mouse doesn't help me. But I do see that if I click on the message body and then click outside the message (like in the message list for that article) then scrolling still fails - again unlike "regular" mail.

Comment 14

[Michel]

I can confirm that, on Linux, it doesn't scroll unless you click inside the message.
Additionally, it doesn't move to the next unread message at the end of the message.

Comment 15

[Alessandro Castellani [:aleca]]

Thanks for the report and for confirming the issues.
We will try to get this fixed before next ESR.

Comment 16

[Alessandro Castellani [:aleca]]

This seems to work on macOS but fails on Windows and Linux...that is so weird!
I'm gonna ping a bunch of folks to get some feedback on their specific OSs.

Toby, can you test this on Window?
Vineet, can you test this on macOS?
Magnus, can you test this on Linux?

Please try both 115 and daily/trunk

Comment 17

[Vineet Deo]

Tested on daily and 115 on macOS, works like intended.

Comment 18

[Toby Pilling [:tobyp]]

On Windows I found a slight inconsistency between versions but largely reproduced the issue. Interesting that setting it to default works differently for Thunderbird feed vs Slashdot...

Local build

---

Slashdot Web Page - doesn't work
Slashdot Summary - works ok
Slashdot Default - doesn't work
Thunderbird Web Page - doesn't work
Thunderbird Summary - works ok
Thunderbird Default - works ok

Daily

---

Slashdot Web Page - doesn't work
Slashdot Summary - works ok
Slashdot Default - doesn't work
Thunderbird Web Page - doesn't work
Thunderbird Summary - works ok
Thunderbird Default - doesn't work

115

---

Slashdot Web Page - doesn't work
Slashdot Summary - works ok
Slashdot Default - doesn't work
Thunderbird Web Page - doesn't work
Thunderbird Summary - works ok
Thunderbird Default - doesn't work

Comment 19

[Alex Schmitz]

Attachment: Bug 1830755 - Add messageScroll actor to handle communication related to scrolling the message browser. r=#thunderbird-front-end-reviewers

Comment 20

[Hartmut Welpmann [:welpy-cw]]

Apparently this patch doesn't solve the issue, at least in my tests on Linux. While the underlying problem may be somewhat random and seems to vary on different platforms, I think it's exactly what's discussed in bug 1468925. Perhaps the patch there is a pragmatic solution for now.

Comment 21

[Alex Schmitz]

The bug your referencing is an entirely different bug with the opposite issue. this bug is that it ONLY advances to the next messages and does not scroll. The bug your referencing is about it not going to the next message.

Comment 22

[Hartmut Welpmann [:welpy-cw]]

Apologies, I completely misunderstood the purpose of this bug. While careful reading of this entire report might have prevented this, I just couldn't reproduce any particular problem with feed messages, regardless of whether "Show article summary instead of loading web page" was enabled or not.

Only after some digging on Searchfox did I learn that there is a preference rss.show.summary that defaults to "global override, load summary". While this setting itself doesn't show up in the GUI, it prevents all the "Show article summary..." checkboxes under feed subscriptions from having any effect. Not really great UX in my opinion. Anyway, after manually disabling that global override I can reproduce and understand the issue.

Comment 23

[Hartmut Welpmann [:welpy-cw]]

After being pointed to the How to by a really nice person, please disregard my uninformed opinion in the second paragraph of the previous comment.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/be58bef28f3e
Add messageScroll actor to handle communication related to scrolling the message browser. r=aleca,freaktechnik

Comment 25

[Alex Schmitz]

Attachment: Bug 1830755 - Follow up: Fix jsDocs for message scroll actors. r=#thunderbird-reviewers

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e381135c90fb
Follow up: Fix jsDocs for message scroll actors. r=aleca DONTBUILD

Comment 27

[Magnus Melin [:mkmelin]]

Attachment: Bug 1830755 - Follow-up v2: fix jsdocs. r=arschmitz

Comment 28

[Magnus Melin [:mkmelin]]

Backed out for test failures:
https://treeherder.mozilla.org/jobs?repo=comm-central&revision=b8ef6c98e95beee82fa9c16d8c8290c941563c7a&selectedTaskRun=ahM6Or84T-SdKIQI4de26A.0

Backout:
https://hg.mozilla.org/comm-central/rev/1004d5c2ab1e20919933c2021ec51cd7b45c0098
https://hg.mozilla.org/comm-central/rev/f3787d0a8155bc32ef04611c4a5fbc104e056d76

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b0a279116884
Add messageScroll actor to handle communication related to scrolling the message browser. r=freaktechnik,aleca

Comment 30

[Magnus Melin [:mkmelin]]

comm/mail/base/test/browser/browser_feedBodyScroll.js is failing for debug on multiple platforms:
https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=J0xQrkJ_TXm1-_4lC1zBlw.0
https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=ZSv4efmuRwqMolPddbg2mg.0

Comment 31

[Magnus Melin [:mkmelin]]

Also CCov builds: https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=B0bZROeWQ3W1N8-nlZAR0A.0