Closed Bug 1948793 Opened 1 year ago Closed 1 year ago

Intermittent comm/mail/base/test/browser/browser_feedBodyScroll.js | Test timed out

Categories

(Thunderbird :: Message Reader UI, defect, P5)

defect

Tracking

(thunderbird_esr128 unaffected)

RESOLVED FIXED
137 Branch
Tracking Status
thunderbird_esr128 --- unaffected

People

(Reporter: intermittent-bug-filer, Assigned: mkmelin)

References

(Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression)

Attachments

(3 files)

This was from bug 1830755

Flags: needinfo?(arschmitz)
Keywords: regression
Regressed by: 1830755

From my observations, the test times out because the listener for the
scroll event is registered after the keypress event has been issued.

Since the EventUtils are also available inside a spawned SpecialPowers,
this patch moves the call to EventUtils.synthesizeKey() inside and
after the registration of the scroll event.

Assignee: nobody → john
Status: NEW → ASSIGNED
Target Milestone: --- → 137 Branch

Pushed by john@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/736a4251b5b0
Attempt to fix browser_feedBodyScroll.js. r=vineet

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Still happening (but not as frequently?)

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Make it pass with --headless --verify and other things

If this continues to fail, we might have to consider using a different test approach. A single keystroke may cause multiple scroll events.

Since we only wait for one, the next time we wait for the scroll from the keystroke, it could be resolved by one of the other scroll events from the prior keystroke. We probably have to wait until no more scroll events are issued. The scrollend event is also not helpful, since it does not mark the end of scroll, there will be more scroll events after it. See Bug 1869514.

Attachment #9469687 - Attachment description: Bug 1948793 - Fixes to intermittent comm/mail/base/test/browser/browser_feedBodyScroll.js. r=#thunderbird-reviewers → Bug 1948793 - Fixes to intermittent comm/mail/base/test/browser/browser_feedBodyScroll.js. r=freaktechnik
Assignee: john → mkmelin+mozilla

Pushed by brendan@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/622c14b21f6c
Fixes to intermittent comm/mail/base/test/browser/browser_feedBodyScroll.js. r=freaktechnik

Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
Assignee: mkmelin+mozilla → nobody
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

(In reply to John Bieling (:TbSync) from comment #9)

Since we only wait for one, the next time we wait for the scroll from the keystroke, it could be resolved by one of the other scroll events from the prior keystroke. We probably have to wait until no more scroll events are issued. The scrollend event is also not helpful, since it does not mark the end of scroll, there will be more scroll events after it. See Bug 1869514.

It seems to me it should use "scrollend" actually, instead of "scroll". What did you mean by this? We do one scroll at a time and then wait for the event

Flags: needinfo?(john)

If you log "scroll" and "scrollend" events continuously, you will see that a scrollend event is not the last event resulting from a scroll. A single scroll action from A to B will cause multiple "scroll" events, one "scrollend" event and then some more "scroll" events.

Flags: needinfo?(john)

I wonder if that's not about something else.
https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollend_event says "The scrollend event fires when element scrolling has completed". I think that's all we care about.

A try run with "scrollend" seems alright: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=f7cb14130cfe659a44af648f8cf161ff0f710ff6&selectedTaskRun=auW1YRWFQZmuU7aZINWUUg.0

Flags: needinfo?(arschmitz)
Assignee: nobody → mkmelin+mozilla
Attachment #9473091 - Attachment description: Bug 1948793 - Fix intermittent comm/mail/base/test/browser/browser_feedBodyScroll.js by listning for scrollend instead of scroll. r=john.bieling → Bug 1948793 - Fix intermittent comm/mail/base/test/browser/browser_feedBodyScroll.js by listening for scrollend instead of scroll. r=john.bieling

Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/6720bb57b08a
Fix intermittent comm/mail/base/test/browser/browser_feedBodyScroll.js by listening for scrollend instead of scroll. r=freaktechnik

Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: