Link on newtab don't work if you pull the newtab into a new window
Categories
(Firefox :: New Tab Page, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox112 | --- | unaffected |
firefox113 | --- | unaffected |
firefox114 | + | verified |
firefox115 | --- | verified |
People
(Reporter: thecount, Assigned: enndeakin)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Step to reproduce:
- Open a newtab
- Drag that tab out of that browser, and have it create a new one. (You'll probably need a second tab open in that original window, not sure)
- Click on a topsite or Pocket story.
Expected: Should open that link
Actual: It does not.
Reporter | ||
Updated•2 years ago
|
Reporter | ||
Comment 1•2 years ago
|
||
I did a bisect and it looks like this was caused by https://phabricator.services.mozilla.com/D171604
Reporter | ||
Comment 2•2 years ago
|
||
I suspect this is also causing bug 1828019
Comment 3•2 years ago
|
||
Set release status flags based on info from the regressing bug 1814210
:enndeakin, since you are the author of the regressor, bug 1814210, could you take a look? Also, could you set the severity field?
For more information, please visit BugBot documentation.
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
Updated•2 years ago
|
Comment 6•2 years ago
|
||
Set release status flags based on info from the regressing bug 1814210
Comment 7•2 years ago
|
||
Neil, this is marked as S2 and has a patch, are you planning to land and request beta uplift?
Comment 11•2 years ago
|
||
Comment 12•2 years ago
|
||
Backed out for causing bc failures in browser_topsites_contextMenu_options.js
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_topsites_contextMenu_options.js | Number of options is correct - 6 == 5 - got 6, expected 5 (operator ==)
Comment 13•2 years ago
|
||
Comment 14•2 years ago
|
||
bugherder |
Assignee | ||
Updated•2 years ago
|
Comment 15•2 years ago
|
||
I‘ve verified this issue using the latest Firefox Nightly 115.0a1 (Build ID: 20230521210743) on Windows 10 x64, macOS 11.7.1, and Ubuntu 22.04 x64.
- Topsites and Pocket stories links work correctly when dragging a new tab into a window.
Comment 16•2 years ago
•
|
||
Comment on attachment 9331500 [details]
Bug 1830911, update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=mardak
Beta/Release Uplift Approval Request
- User impact if declined: Newtab links stop working
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes comment 15
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Comment 0
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Relatively small and contained newtab JS change to detect window changes to maintain the correct browser mapping
- String changes made/needed: none
- Is Android affected?: No
Updated•2 years ago
|
Comment 17•2 years ago
|
||
Comment on attachment 9331500 [details]
Bug 1830911, update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=mardak
Approved for 114 beta 8, thanks.
Comment 18•2 years ago
|
||
bugherder uplift |
Updated•2 years ago
|
Comment 19•2 years ago
|
||
I have verified that this issue is no longer reproducible using the latest Firefox Beta 114.0 (Build ID: 20230529085652) on Windows 10 x64, macOS 13.2, and Ubuntu 22.04 x64. I can confirm that Top Sites and Pocket stories links work correctly when dragging a new tab into a window.
Description
•