1830911 - Link on newtab don't work if you pull the newtab into a new window

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Scott [:thecount] Downe]

Step to reproduce:

1. Open a newtab
2. Drag that tab out of that browser, and have it create a new one. (You'll probably need a second tab open in that original window, not sure)
3. Click on a topsite or Pocket story.

Expected: Should open that link
Actual: It does not.

Comment 1

[Scott [:thecount] Downe]

I did a bisect and it looks like this was caused by https://phabricator.services.mozilla.com/D171604

Comment 2

[Scott [:thecount] Downe]

I suspect this is also causing bug 1828019

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1814210

:enndeakin, since you are the author of the regressor, bug 1814210, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Neil Deakin]

Attachment: Bug 1830911, update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=mardak

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1814210

Comment 7

[Pascal Chevrel:pascalc]

Neil, this is marked as S2 and has a patch, are you planning to land and request beta uplift?

Comment 8

[Neil Deakin]

Yes, once it has been reviewed.

Comment 9

[Pascal Chevrel:pascalc]

Ed, could you review the patch please? thanks

Comment 10

[Ed Lee :Mardak]

Oh wow really sorry for the delay!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8813323684b7
update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=Mardak

Comment 12

[Cristian Tuns]

Backed out for causing bc failures in browser_topsites_contextMenu_options.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_topsites_contextMenu_options.js | Number of options is correct - 6 == 5 - got 6, expected 5 (operator ==)

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51e7bb57ca5a
update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=Mardak

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/51e7bb57ca5a

Comment 15

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the latest Firefox Nightly 115.0a1 (Build ID: 20230521210743) on Windows 10 x64, macOS 11.7.1, and Ubuntu 22.04 x64.

• Topsites and Pocket stories links work correctly when dragging a new tab into a window.

Comment 16

[Ed Lee :Mardak]

Comment on attachment 9331500 [details]
Bug 1830911, update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=mardak

Beta/Release Uplift Approval Request

• User impact if declined: Newtab links stop working
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes comment 15
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively small and contained newtab JS change to detect window changes to maintain the correct browser mapping
• String changes made/needed: none
• Is Android affected?: No

Comment 17

[Pascal Chevrel:pascalc]

Comment on attachment 9331500 [details]
Bug 1830911, update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=mardak

Approved for 114 beta 8, thanks.

Comment 18

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/31ac52f1317b

Comment 19

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Beta 114.0 (Build ID: 20230529085652) on Windows 10 x64, macOS 13.2, and Ubuntu 22.04 x64. I can confirm that Top Sites and Pocket stories links work correctly when dragging a new tab into a window.