Closed Bug 1830911 Opened 2 years ago Closed 2 years ago

Link on newtab don't work if you pull the newtab into a new window

Categories

(Firefox :: New Tab Page, defect)

defect

Tracking

()

VERIFIED FIXED
115 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox112 --- unaffected
firefox113 --- unaffected
firefox114 + verified
firefox115 --- verified

People

(Reporter: thecount, Assigned: enndeakin)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Step to reproduce:

  1. Open a newtab
  2. Drag that tab out of that browser, and have it create a new one. (You'll probably need a second tab open in that original window, not sure)
  3. Click on a topsite or Pocket story.

Expected: Should open that link
Actual: It does not.

Keywords: regression
Regressed by: 1814210

I did a bisect and it looks like this was caused by https://phabricator.services.mozilla.com/D171604

I suspect this is also causing bug 1828019

Set release status flags based on info from the regressing bug 1814210

:enndeakin, since you are the author of the regressor, bug 1814210, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Assignee: nobody → enndeakin
Severity: -- → S2
Status: NEW → ASSIGNED
Flags: needinfo?(enndeakin)
See Also: → 1831596
Duplicate of this bug: 1831596
See Also: 1831596

Set release status flags based on info from the regressing bug 1814210

Neil, this is marked as S2 and has a patch, are you planning to land and request beta uplift?

Flags: needinfo?(enndeakin)

Yes, once it has been reviewed.

Flags: needinfo?(enndeakin)

Ed, could you review the patch please? thanks

Flags: needinfo?(edilee)

Oh wow really sorry for the delay!

Flags: needinfo?(edilee)
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8813323684b7 update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=Mardak

Backed out for causing bc failures in browser_topsites_contextMenu_options.js

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_topsites_contextMenu_options.js | Number of options is correct - 6 == 5 - got 6, expected 5 (operator ==)
Flags: needinfo?(enndeakin)
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/51e7bb57ca5a update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=Mardak
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
Flags: needinfo?(enndeakin)

I‘ve verified this issue using the latest Firefox Nightly 115.0a1 (Build ID: 20230521210743) on Windows 10 x64, macOS 11.7.1, and Ubuntu 22.04 x64.

  • Topsites and Pocket stories links work correctly when dragging a new tab into a window.
Status: RESOLVED → VERIFIED

Comment on attachment 9331500 [details]
Bug 1830911, update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=mardak

Beta/Release Uplift Approval Request

  • User impact if declined: Newtab links stop working
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes comment 15
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Relatively small and contained newtab JS change to detect window changes to maintain the correct browser mapping
  • String changes made/needed: none
  • Is Android affected?: No
Attachment #9331500 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9331500 [details]
Bug 1830911, update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=mardak

Approved for 114 beta 8, thanks.

Attachment #9331500 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have verified that this issue is no longer reproducible using the latest Firefox Beta 114.0 (Build ID: 20230529085652) on Windows 10 x64, macOS 13.2, and Ubuntu 22.04 x64. I can confirm that Top Sites and Pocket stories links work correctly when dragging a new tab into a window.

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: