1831057 - Handle conflict interactions between popover, modal dialog and fullscreen

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[zsun]

https://github.com/openui/open-ui/issues/520

Comment 1

[zsun]

Attachment: Bug 1831057 - Handle conflict interactions between popover, modal dialog and fullscreen. r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1a398764f9e
Handle conflict interactions between popover, modal dialog and fullscreen. r=emilio

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing wpt failures in popover-top-layer-combinations.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-PASS | /html/semantics/popovers/popover-top-layer-combinations.html | Popover combination: Fullscreen Popover - expected FAIL

Comment 4

[zsun]

I have updated the patch with test expectation [Pass, Fail]. This test fails in my local run and shows Fail at https://searchfox.org/mozilla-central/source/testing/web-platform/meta/html/semantics/popovers/popover-top-layer-combinations.html.ini. Not sure how it managed to pass. We will file a ticket to look into at a later stage.

Comment 5

[zsun]

@emilio, I have updated the patch to address the issue that caused backing out. Any chance to take another look at the patch? Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f850ba94d7c
Handle conflict interactions between popover, modal dialog and fullscreen. r=emilio

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/5f850ba94d7c