1831224 - Dragging message from advanced `Search Messages` dialogue to desktop doesn't work

Status: VERIFIED FIXED

(Thunderbird :: Search, defect, P2)

Description

[BB]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36 Edg/112.0.1722.68

Steps to reproduce:

Dragging message from Search Messages dialogue to desktop doesn't work.

Error console shows:
Uncaught ReferenceError: messageFlavorDataProvider is not defined
ThreadPaneOnDragStart chrome://messenger/content/threadPane.js:158
ondragstart chrome://messenger/content/SearchDialog.xhtml:1

Apparently treadPane.js is being deprecated, see bug 1455429 comment #13.

Also see bug 1824317. It's unclear which search is affected there.

Comment 1

[Thomas D. (:thomas8)]

Thank you for reporting this. Not easy to work around afasics, so for affected users of Advanced Search, this can be a deal breaker.

STR

1. Edit > Find > Search messages (Ctrl+Shift+F)
2. From Advanced "Search Messages" dialog, drag a message to a file folder, e.g. Desktop.

Actual

• nothing, fails with error (see comment 0)

Expected

• find .eml file in the folder, e.g. Desktop

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1831224 - Rework mailWindow.js lint inclusions and fix dragging message from advanced `Search Messages` dialogue to desktop. r=leftmostcat

The cause of the non-working dragndrop was a missing include in SearchDialog.js, in combination with wanting a global messenger that doesn't exist in the given place.
I cleaned up the linting rules to avoid including mailWindow.js where not needed - due to the recursive nature of import-globals-from it many times hid a lot of bugs that should have been obvious otherwise. Mostly this is moving code around to where it's actually used, and inlining some onelines.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5d6d14c2f8db
Rework mailWindow.js lint inclusions and fix dragging message from advanced Search Messages dialogue to desktop. r=leftmostcat

Comment 4

[BB]

Thanks!

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9331737 [details]
Bug 1831224 - Rework mailWindow.js lint inclusions and fix dragging message from advanced Search Messages dialogue to desktop. r=leftmostcat

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 114.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/92b5154095be