1831248 - Password not hidden after clicking 'Hide password' button while creating new login on 'about:logins' page.

Status: VERIFIED FIXED

(Firefox :: about:logins, defect)

Description

[buglinking]

Attachment: Screen Recording 2023-05-04 at 15.21.04.mov

[Affected versions]:

114.0a1 (2023-05-03) (64-bit)

[Affected Platforms]:

macOS 13.3.1 (22E261)

[Steps to reproduce]:

1. Open the latest Nightly browser.
2. Navigate to "about:logins" page.
3. Click the "Create new login" button.
4. Enter the password.
5. Click the "Show password" button.
6. Click the "Hide password" button.

[Expected Results]:
The password should be hidden.

[Actual Results]:
The password is still being displayed.

Comment 1

[buglinking]

Hello, as a beginner, I would like to fix this bug as my first contribution. Could I be assigned to work on this bug?

Comment 2

[Sergey Galich [:serg]]

Hey buglinking, thanks for catching this one!

I believe Micah is working to remove that reveal button completely, I'll let her decide if we want to fix it here or it will not be a problem because there will be no such button.

Comment 3

[nicoleta.sibisan]

Issue reproduced, with the indicated steps, on MacOs 12 and Win 11 with Fx versions 113.0b9, 114.0a1 (2023-05-04).
It does not reproduce with Fx versions: 102.11.0esr and 112.0.2.

Mozregression info:

• pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c47b3b28fb48c01c33585b46650249b182cabe00&tochange=202e0c83904e34c29c06d6b64c4476275998c0e5
• "Bug 1654665 - Unmask password field when editing and field is focused. r=credential-management-reviewers,sgalich"

Related behaviour - on affected versions, the Password is automatically hidden when focus is switched from the Password input field:

1. Launch Firefox.
2. Go to about:logins page.
3. Create new login.
4. Use Tab to navigate to the Show/Hide Password button.
5. Once it is in focus, press Space.

Actual results:

• unaffected Fx versions : the focus is maintained on the Show/Hide button and the button works as expected.
• affected Fx versions: the focus switches to the Password input field and the pass is visible.
  Switch focus to any other area and the password becomes hidden. Click on the Pass input field, the pass remains hidden.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1654665

Comment 5

[Micah [:mtigley] (she/her)]

Apologies for the delay here.

The work for removing the password button is just about there. The remaining work requires tests to be fixed. I don't have an estimate for when that will be finished, so I propose a temporary workaround in the meantime:

I've narrowed the issue down to this block of code: https://searchfox.org/mozilla-central/rev/11a4d97a7b5cdfa133f4bda4525649f651703018/browser/components/aboutlogins/content/components/login-item.mjs#330-334. When the reveal button is clicked, the password input receives the "blur" event, which causes the reveal checkbox to toggle the password visibility again.

Perhaps a temporary workaround is to avoid focusing the field when the reveal button is clicked at _updatePasswordRevealState. Serg, let me know what you think!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

IMO, getting a spot fix landed for this instead of waiting for bug 1750072 would make sense.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Micah, should we assign this bug to somebody? The reporter maybe? Thanks!

Comment 8

[buglinking]

(In reply to Pascal Chevrel:pascalc from comment #7)

Micah, should we assign this bug to somebody? The reporter maybe? Thanks!

I'm glad to fix it! Thanks

Comment 9

[Sergey Galich [:serg]]

buglinking feel free to attach the patch, it will automatically assign this bug to you. Thank you!

Comment 10

[buglinking]

(In reply to Sergey Galich [:serg] from comment #9)

buglinking feel free to attach the patch, it will automatically assign this bug to you. Thank you!
It is my first time to try to fix a bug, could you please be my mentor?

Comment 11

[Micah [:mtigley] (she/her)]

Hi buglinking! Is this your first time contributing to Firefox? It'll be good to make sure you've completed the steps outlined here: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#firefox-contributors-quick-reference

Comment 12

[Donal Meehan [:dmeehan]]

:serg has there been any progress on mentoring this bug or a timeline on a fix?
Wondering what expectations we have around fix in time for 115?

Comment 13

[Issam Mani [:issammani]]

Attachment: Bug 1831248 - Fix conceal/show button not working properly. r=mtigley!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0547cc178179
Fix conceal/show button not working properly. r=mtigley

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0547cc178179

Comment 16

[Issam Mani [:issammani]]

Attachment: Bug 1831248 - Fix conceal/show button not working properly. r=mtigley!

Fixes password input behaviour.

• The password text will be revealed when focused from oustide (i.e not triggered by reveal button )
• The password text will be concealed when blurred.
• The password text will show / hide depending on reveal button state. Edit is possible when password is hidden by reveal button.

Old behaviour:
{F4936523}

Current behaviour:
{F4936530}

Original Revision: https://phabricator.services.mozilla.com/D180979

Comment 17

[Phabricator Automation]

Uplift Approval Request

• User impact if declined: Users are not able to conceal their password while typing in about:logins form
• Fix verified in Nightly: no
• Is Android affected?: no
• Steps to reproduce for manual QE testing: See videos attached in patch.
• Code covered by automated testing: no
• Needs manual QE test: no
• Risk associated with taking this patch: None
• String changes made/needed: No
• Explanation of risk level: The user is able to hide their password while typing in an input in about:logins. No risk is associated with this patch.

Comment 18

[Phabricator Automation]

Uplift Approval Request

• Risk associated with taking this patch: None
• Needs manual QE test: no
• String changes made/needed: No
• Explanation of risk level: The user is able to hide their password while typing in an input in about:logins. No risk is associated with this patch.
• User impact if declined: Users are not able to conceal their password while typing in about:logins form
• Fix verified in Nightly: no
• Is Android affected?: no
• Steps to reproduce for manual QE testing: See videos attached in patch.
• Code covered by automated testing: no

Comment 19

[Donal Meehan [:dmeehan]]

Comment on attachment 9339449 [details]
Bug 1831248 - Fix conceal/show button not working properly. r=mtigley!

Approved for 115.0b7.

Comment 20

[Ardelean Oana, Desktop QA [:oardelean]]

Reproducible on a 2023-06-13 Nightly build on Windows 10 using the steps from Comment 0.
Verified as fixed on Firefox 115.0b7(build ID: 20230618180218) and Nightly 116.0a1(build ID: 20230619213151) on Windows 10, macOS 12, Ubuntu 22.
The ‘eye’ button now works accordingly.