Remove dead code after bug 1828413
Categories
(Firefox :: Theme, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox115 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
After bug 1828413 I left the old code disabled behind a pref just in case it broke in some environment. We can remove that code now the merge has happened.
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/752dc76b26eb Remove dead GTK menu styling code. r=dao,stransky
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 4•1 year ago
|
||
Same fix as above, let it be styled as a regular toolbar. This works on
Light and dark native themes as well.
Depends on D177882
|
|
Assignee | |
Comment 5•1 year ago
|
||
We only use this in one place in navigator-toolbox.inc.xhtml, and it
doesn't work anymore for the same reason as the previous patch.
A lot of the styling is redundant with the toolbar rule above anyways.
appearance: toolbar can't do anything fancy, actually, because we don't
have colors for it so it can't render much. I think we should probably
just remove that but that would be a follow-up.
Depends on D177883
|
||
Comment 6•1 year ago
|
||
Comment on attachment 9333293 [details]
Bug 1831841 - Remove menubar appearance usage from #placesToolbar on Linux. r=dao,mak,stransky
Revision D177883 was moved to bug 1832732. Setting attachment 9333293 [details] to obsolete.
|
|
||
Comment 7•1 year ago
|
||
Comment on attachment 9333294 [details]
Bug 1831841 - Remove redundant and now-broken toolbar[type="menubar"] styling. r=dao,stransky
Revision D177884 was moved to bug 1832732. Setting attachment 9333294 [details] to obsolete.
Description
•