1832732 - Wrong text color in the tabbar with dark system theme on Linux

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Danny Colin [:sdk]]

Attachment: wrong-color.png

bug 1831841 introduced a regression where the foreground color (text, icon) is black when using the system dark theme on Linux.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4e43ca74c9198f6c01d64095bd77e8f2441eed95&tochange=752dc76b26eb54e7dfa875c749e91526496688b6

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Ah, this only happens without CSD, and I see why.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1832732 - Improve menubar and tabs toolbar styling consistency with and without CSD. r=dao,stransky

In bug 1831841 I removed the menubar text colors, because the menubar is
now non-natively styled, but I missed they are used in this case.

Let's just let color inherit through like we do for CSD and non-native
themes.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1832732 - Remove menubar appearance usage from #placesToolbar on Linux. r=dao,mak,stransky

Same fix as above, let it be styled as a regular toolbar. This works on
Light and dark native themes as well, and actually fixes some contrast
issues in some themes like Colloid-Green for example.

Depends on D177882

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1832732 - Remove redundant and now-broken toolbar[type="menubar"] styling. r=dao,stransky

We only use this in one place in navigator-toolbox.inc.xhtml, but we
style it as transparent.

A lot of the styling is redundant with the toolbar rule above anyways.

appearance: toolbar can't do anything fancy, actually, because we don't
have text colors for it so it can't render much different as a
background anyways. I think we should probably just remove that but that
would be a follow-up.

Depends on D177883

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5868f3e8b379
Improve menubar and tabs toolbar styling consistency with and without CSD. r=dao
https://hg.mozilla.org/integration/autoland/rev/a74e74917efd
Remove menubar appearance usage from #placesToolbar on Linux. r=dao
https://hg.mozilla.org/integration/autoland/rev/e1a8f01d9769
Remove redundant and now-broken toolbar[type="menubar"] styling. r=dao

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14c4908a2037
Tweak browser_startup_flicker exception now that linux without CSD reacts to windows visually.

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5868f3e8b379
https://hg.mozilla.org/mozilla-central/rev/a74e74917efd
https://hg.mozilla.org/mozilla-central/rev/e1a8f01d9769
https://hg.mozilla.org/mozilla-central/rev/14c4908a2037