1832395 - "Tray icon always on" has stopped working

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[BB]

+++ This bug was initially created as a clone of Bug #1727874 +++

"Tray icon always on" has stopped working, in Daily it works sometimes, other times it doesn't. In slower debug builds, it mostly doesn't work.

We debugged it and it turns out that "profile-after-change" does not fire any more
https://searchfox.org/comm-central/search?q=profile-after-change&path=MailNotificationManager.jsm&case=false&regexp=false

Likely that MailNotificationManager is initialized later now after "profile-after-change" has already run. We recommend to run this._updateUnreadCount(); directly.

Comment 1

[BB]

We like the feature, so we would like to see it working in TB 115:
https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1832395-fix-tray-icon-always-on.patch

Comment 2

[BB]

Likely regressed here: https://hg.mozilla.org/comm-central/rev/17ad6ea84651

Comment 3

[Anton Parygin]

I was the author of the "keep tray icon" change, however I'm out of my depth here with how the events firing sequence changed and may need some assistance on where from to call the init method now?

Comment 4

[BB]

Just take the patch, attach it here and ask for review. Can you confirm that it doesn't work reliably in Daily or beta? For us it fails about every third time.

Comment 5

[Thomas D. (:thomas8)]

John, is this add-on territory? wrt "profile-after-change" does not fire any more.
Also: would you think that this is related to sn-3pane changes?

(In reply to BB from comment #0)

We debugged it and it turns out that "profile-after-change" does not fire any more
https://searchfox.org/comm-central/search?q=profile-after-change&path=MailNotificationManager.jsm&case=false&regexp=false

Likely that MailNotificationManager is initialized later now after "profile-after-change" has already run. We recommend to run this._updateUnreadCount(); directly.

^^ Geoff, fyi. Recommendation to "run this._updateUnreadCount(); directly" reminded me of bug 1833345. Otherwise, just ignore.

Comment 6

[John Bieling]

This is not code I am involved with or have deeper knowledge. I can confirm, that profile-after-change is not fired and this is never executed:
https://searchfox.org/comm-central/rev/1045fa69e30893e86041a615f0bdfd4bc78bfa21/mailnews/base/src/MailNotificationManager.jsm#120-123

I do not think this is add-on related, but this change in core stopped working.

Comment 7

[Sean Burke [:leftmostcat]]

This issue here appears to be in our expectations: we expect MailNotificationService to notify us of an update to the unread message count some time after we've registered a listener for it. However, it now sends out the notification on startup and we can only listen after it's started.

Comment 8

[Fred Vanderstein]

Does the patch from comment #1 not work?

Comment 9

[Sean Burke [:leftmostcat]]

(In reply to Fred Vanderstein from comment #8)

Does the patch from comment #1 not work?

That patch will be the basis of the fix, but some additional work is needed around it before it can be merged.

Comment 10

[Sean Burke [:leftmostcat]]

Attachment: Bug 1832395 - Ensure listeners have accurate new/unread mail count on startup. r=darktrojan

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/78947f14f83d
Ensure listeners have accurate new/unread mail count on startup. r=darktrojan

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9337930 [details]
Bug 1832395 - Ensure listeners have accurate new/unread mail count on startup. r=darktrojan

[Triage Comment]
Approved for beta

Comment 13

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/42c392e46078