1832942 - buttons in unified toolbar customize panel could be visually improved

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, enhancement)

Description

[Sören Hentzschel]

Attachment: screenshot

The buttons in the unified toolbar customize panel looks a bit unbalanced, especially with some buttons with one line of text and others with two lines of text.

I suggest do vertically center the text of the buttons. Also there should be some padding on the top and the bottom of the buttons so that the button content don't stick to the edges so much.

Tested on Thunderbird Daily 115.0a1 (2023-05-12) on macOS 13.3.1.

Comment 1

[Thomas D. (:thomas8)]

Adding [Supernova3p] to whiteboard. 20230515_1337

Comment 2

[Alessandro Castellani [:aleca]]

Let's increase the padding of the text fields inside the buttons.
Try to make the ellipses work.
Limit the text label to 2 lines max.
Use title tag for tooltips.

Comment 3

[[e-mail]]

Attachment: Bug 1832942 - Improve label styles for buttons in unified toolbar customize panel. r=#thunderbird-front-end-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/410a524c1734
Improve label styles for buttons in unified toolbar customize panel. r=freaktechnik

Comment 5

[[e-mail]]

Comment on attachment 9337103 [details]
Bug 1832942 - Improve label styles for buttons in unified toolbar customize panel. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #):

User impact if declined:
Labels for the Unified Toolbar customization are more likely to be clipped in a way that makes them much more difficult to read.

Testing completed (on c-c, etc.):
both automated and manual testing on daily.

Risk to taking this patch (and alternatives if risky):
Minimal risk as this is mostly css changes

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9337103 [details]
Bug 1832942 - Improve label styles for buttons in unified toolbar customize panel. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 115.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/33e937fa220a