1838519 - buttons in unified toolbar customize panel could be visually improved, part 2

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, enhancement, P3)

Description

[Sören Hentzschel]

Attachment: mockup

+++ This bug was initially created as a clone of Bug #1832942 +++

The buttons in the unified toolbar customize panel were improved in bug 1832942 but the visiual appearance did not change much, the buttons still look unbalanced. I think one reason for this is the missing padding at the bottom if the text has two lines. Well, technically there is a padding but the text overflows due to the fixed height of the button. I suggest to at least increase the height of the buttons. Please see the attached mockup.

Comment 1

[Alessandro Castellani [:aleca]]

Some nice to have UI improvements we can potentially tackle for a point release.

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: Bug 1838519 - Scale toolbar customization palette items according to their contents. r=#thunderbird-front-end-reviewers

Comment 3

[Martin Giger [:freaktechnik]]

Ah, sorry hadn't seen you had assigned this to micah.

Comment 4

[Alessandro Castellani [:aleca]]

No problem, it was just a tentative bug organization but since you have a working patch you can snatch it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c3f57d2ff160
Scale toolbar customization palette items according to their contents. r=aleca

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c0e388f36e58
Backed out changeset c3f57d2ff160 for causing test failures. r=bustage

Comment 7

[Kai Engert (:KaiE:)]

Backed out for causing the following test failures:

TEST-UNEXPECTED-FAIL | comm/mail/components/unifiedtoolbar/test/browser/browser_unifiedToolbarCustomization.js | Save button is enabled - false == true - {"filename":"chrome://mochitests/content/browser/comm/mail/components/unifiedtoolbar/test/browser/browser_unifiedToolbarCustomization.js","name":"test_add_item","sourceId":693,"lineNumber":136,"columnNumber":10,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/cont
TEST-UNEXPECTED-FAIL | comm/mail/components/unifiedtoolbar/test/browser/browser_unifiedToolbarCustomization.js | Test timed out -
TEST-UNEXPECTED-FAIL | comm/mail/components/unifiedtoolbar/test/browser/browser_unifiedToolbarCustomization.js | Unified toolbar state was changed - {} notDeepEqual {} - {"filename":"chrome://mochitests/content/browser/comm/mail/components/unifiedtoolbar/test/browser/browser_unifiedToolbarCustomization.js","name":"test_add_item","sourceId":693,"lineNumber":143,"columnNumber":10,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome
TEST-UNEXPECTED-FAIL | comm/mail/components/unifiedtoolbar/test/browser/browser_unifiedToolbarCustomization.js | Mail space has the expected new unified toolbar state - "undefined" deepEqual ["spacer","move-to"] - {"filename":"chrome://mochitests/content/browser/comm/mail/components/unifiedtoolbar/test/browser/browser_unifiedToolbarCustomization.js","name":"test_add_item","sourceId":693,"lineNumber":148,"columnNumber":10,"sourceLine":"","asyncC
[taskcluster:error] exit status 1

A try run with the backout had worked fine:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=f9c72d9665fdb643346767880a7336548ee99afc

Comment 8

[Martin Giger [:freaktechnik]]

This should be fine now (due to the test having been fixed separately to keep this easily upliftable - since the test landed after the 116 merge).
Rebased windows try: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=78fcd5ecf8d09e694552303db4a5a8bf67b79d17

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dcfcc3b4c8e9
Scale toolbar customization palette items according to their contents. r=aleca

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9342232 [details]
Bug 1838519 - Scale toolbar customization palette items according to their contents. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 116.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/f4fcca0abbfc

Comment 12

[Martin Giger [:freaktechnik]]

Comment on attachment 9342232 [details]
Bug 1838519 - Scale toolbar customization palette items according to their contents. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Weird text clipping with certain density, font family and font size configurations
Testing completed (on c-c, etc.): Tested on beta
Risk to taking this patch (and alternatives if risky): Low risk, CSS only

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9342232 [details]
Bug 1838519 - Scale toolbar customization palette items according to their contents. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr115

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 115.1.0:
https://hg.mozilla.org/releases/comm-esr115/rev/7e736320a67d