1832976 - ./mach try perf fails with "TypeError: PerfParser.save_revision_treeherder() missing 1 required positional argument: 'base_revision_treeherder'"

Status: RESOLVED FIXED

(Testing :: Performance, defect)

Description

[Markus Stange [:mstange]]

./mach try perf fails on the latest mozilla-central. It looks like bug 1831603 added another argument to the save_revision_treeherder function but didn't adjust all its callers.

% ./mach try perf --rebuild 10
Gathering tasks for Pageload (essential) desktop firefox category
Executing raptor queries: 'browsertime 'tp6 'essential, !android 'shippable !-32 !clang, !chrom !geckoview !fenix !safari !custom-car, !bytecode, !live, !profil
estimates: Runs 41 tasks (27 selected, 14 dependencies)
estimates: Total task duration 9:50:42
estimates: In the top 53% of durations
estimates: Should take about 1:05:45 (Finished around 2023-05-13 12:22)
Creating temporary commit for remote...
A try_task_config.json
pushing to ssh://hg.mozilla.org/try
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: recorded push in pushlog
remote: added 1 changesets with 1 changes to 1 files (+1 heads)
remote: 
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/fd0d1ab306ff9ea36f31995e364b0b9a820c5544
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/jobs?repo=try&revision=fd0d1ab306ff9ea36f31995e364b0b9a820c5544
remote: recorded changegroup in replication log in 0.026s
push complete
temporary commit removed, repository restored
Error running mach:

    ['try', 'perf', '--rebuild', '10']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke ``./mach busted`` to check if this issue is already on file. If it
isn't, please use ``./mach busted file try`` to report it. If ``./mach busted`` is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: PerfParser.save_revision_treeherder() missing 1 required positional argument: 'base_revision_treeherder'

  File "/Users/mstange/code/mozilla/tools/tryselect/mach_commands.py", line 528, in try_perf
    return run(command_context, **kwargs)
  File "/Users/mstange/code/mozilla/tools/tryselect/mach_commands.py", line 196, in run
    return mod.run(**kwargs)
  File "/Users/mstange/code/mozilla/tools/tryselect/selectors/perf.py", line 1304, in run
    revisions = PerfParser.run(
  File "/Users/mstange/code/mozilla/tools/tryselect/selectors/perf.py", line 1172, in run
    return PerfParser.perf_push_to_try(
  File "/Users/mstange/code/mozilla/tools/tryselect/selectors/perf.py", line 1082, in perf_push_to_try
    PerfParser.save_revision_treeherder(

Sentry event ID: 460c4da12e084801b1cc0a5c9a91789e

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1831603

Comment 2

[Greg Mierzwinski [:sparky]]

Attachment: Bug 1832976 - Fix issue with missing argument for caching. r?mstange

Comment 3

[Greg Mierzwinski [:sparky]]

Thanks for filing the bug, and the needinfo :mstange! This came from a merge conflict, and I've pushed a patch to fix it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf6b017da7ed
Fix issue with missing argument for caching. r=mstange DONTBUILD

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cf6b017da7ed