1835071 - implement a custom start/stop for running chrome trace to profile benchmarks in CI

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement, P1)

Description

[Kash Shampur [:kshampur] ⌚EST]

See Bug 1823730 and PR https://github.com/sitespeedio/browsertime/pull/1934

Once pageload traces are working as expected we should move forward with this

Comment 1

[Kash Shampur [:kshampur] ⌚EST]

Before looking to make upstream changes, first check how the default implementation works for benchmarks

Comment 2

[Kash Shampur [:kshampur] ⌚EST]

the sp3 profiles are a little useless (not surprising) e.g.

but not entirely useless like in this motionmark one

basically it cuts off too early. I will see if there any existing flags that can extend it, otherwise as suggested in https://bugzilla.mozilla.org/show_bug.cgi?id=1835071#c0, I will make an upstream change to browsertime to expose the start/stop

Comment 3

[Kash Shampur [:kshampur] ⌚EST]

managed to get something working locally,
here is an example ares6 full profile https://profiler.firefox.com/public/3x8m5bhs089m4gv9cz0zbkj0j3xgfghrk9zf7p8/calltree/?globalTrackOrder=30w2&hiddenGlobalTracks=02&hiddenLocalTracksByPid=20796-0w5~20844-0wd~20816-0w3&thread=7&timelineType=category&v=10

Comment 4

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1835071 - Use custom start/stop for running chrome trace to profile benchmarks in CI. r?#perftest

This patch uses the custom browsertime exposed start/stop command
for using the chrome Trace. Previously the logic in browsertime
was intended for profiling pageloads, and would end prematurely before
the benchmark was completed. A similar custom start/stop approach was
done previously for the gecko profiler, and now the same thing is needed
here.

Comment 5

[Kash Shampur [:kshampur] ⌚EST]

just fyi: pr for upstream https://github.com/sitespeedio/browsertime/pull/1988

Comment 6

[Kash Shampur [:kshampur] ⌚EST]

(In reply to Kash Shampur [:kshampur] ⌚EST from comment #5)

just fyi: pr for upstream https://github.com/sitespeedio/browsertime/pull/1988

PR has been merged

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c243e4e632e
Use custom start/stop for running chrome trace to profile benchmarks in CI. r=perftest-reviewers,sparky

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0c243e4e632e