Refactor/clean up chrome trace and gecko profiler in raptor-browsertime
Categories
(Testing :: Raptor, task, P3)
Tracking
(Not tracked)
People
(Reporter: kshampur, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxp])
after Bug 1835065, we'll have a chrome trace class that is very similar to the gecko profile class
Given the similarities it would be a good idea to create a superclass to subclass each
Also while we are at it we should do some general clean up for the profiler related code paths e.g. this loop can be confusing, and make it clearer the difference between --extra-profiler-run an --gecko-profile (or address that as discussed in Bug 1831361)
|
Reporter | |
Updated•1 years ago
|
|
||
Updated•1 years ago
|
|
|
Reporter | |
Comment 1•1 years ago
|
||
We should also move the tar profile files to a test/files folder
|
|
Reporter | |
Comment 2•1 years ago
|
||
we should also clean up this loop https://searchfox.org/mozilla-central/rev/ce049e593c7d062a039938cabccaab4c14b8ebfd/testing/raptor/raptor/browsertime/base.py#515-547
|
|
Reporter | |
Comment 3•1 year ago
|
||
as briefly mentioned in the patch for Bug 1514354
we may consider renaming TRACE_APPS to be more descriptive (e.g. CHROME_TRACE_APPS) or consolidate all the profileable applications into something like PROFILER_APPS
Description
•