183559 - Images not displayed in mail messages in local & POP folders, IMAP OK

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Jim Booth]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.3a) Gecko/20021204
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.3a) Gecko/20021204 (Windows ME)

Images in mail messages are not being displayed.  This is a regression since
20021130 (Mozilla 1.2.1)

Mail displays "Loading Document..." in status line.  Images never load but
appear as missing graphic icons.  This is true whether saved as Template or
Draft, or received in Inbox.   Applies to old messages that previously displayed
properly.  Applies to all my mail personalities and all mail accounts, including
local folders.

Reproducible: Always

Steps to Reproduce:
1. Compose a new message, insert an image from local hard drive (JPG or GIF). 
It displays correctly
2. Save as Template or Draft and close it, then reopen, OR Send it to yourself
and open from inbox
3. No images appear, just a border with missing graphic icon and a mouse cursor
with hourglass. 

Actual Results:  
No images are being displayed.   "Loading Document..." does not disappear from
status line.  

Expected Results:  
Images should display

Comment 1

[Jim Booth]

Upon further searching I found this is a dupe of 180055.  Last version I had
where it worked was 2002110808 (1.2b)

*** This bug has been marked as a duplicate of 180055 ***

Comment 2

[esther]

This bug I see in Local Folders and POP folders only.  I don't see it in
newsgroups (as stated in dup bug) or IMAP folders.  This works in the 12-2 trunk
build, broken in the 12-3 trunk build. The dup bug reported this in 11-13 build.
 This may not be a dup of that bug given the differences, still investigating.

Comment 3

[esther]

I can not reproduce this sceanrio in the builds mentioned in dup bug 18055 nor
in the newsgroup.  Removing dup resolution.  This specific scenario is new and a
regression since 12-2-2002 trunk, it affects saving these types of messages
Saved as Drafts and Template local folders too. 

Comment 4

[esther]

editing the summary, this is specific to Local folders.

Comment 5

[Jean-Francois Ducarroz]

accepting

Comment 6

[esther]

Sorry the dup I removed this from is 180055

Comment 7

[Jean-Francois Ducarroz]

I can reproduce the problem with my debug build but I still don't have a clue!

Comment 8

[Jean-Francois Ducarroz]

David modify the pop protocol Tuesday early in the morning:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=&subdir=mozilla/mailnews/local/src&command=DIFF_FRAMESET&root=&file=nsMailboxProtocol.cpp&rev1=1.106&rev2=1.107

maybe it the cause of that regression!

Comment 9

[Jean-Francois Ducarroz]

I backed up file nsMailboxProtocol.cpp to version 1.06 and the problem went
away. This is a regression caused by the fix for bug 179162.

Reassign to bienvenu, I am sure he can figure out the problem faster than me...

Comment 10

[David :Bienvenu]

Attachment: proposed fix

the old code, before I broke this, was passing in the channel listener as the
consumer, so I restored that behaviour.

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 108310 [details] [diff] [review]
proposed fix

sr=sspitzer

Comment 12

[Jean-Francois Ducarroz]

Comment on attachment 108310 [details] [diff] [review]
proposed fix

this patch fix the problem. R=ducarroz

Comment 13

[David :Bienvenu]

Comment on attachment 108310 [details] [diff] [review]
proposed fix

requesting 1.3 approval

Comment 14

[Jean-Francois Ducarroz]

*** Bug 183567 has been marked as a duplicate of this bug. ***

Comment 15

[Brendan Eich [:brendan]]

Comment on attachment 108310 [details] [diff] [review]
proposed fix

a=[e-mail] for 1.3a checkin.

/be

Comment 16

[David :Bienvenu]

fix checked in.

Comment 17

[David :Bienvenu]

*** Bug 183709 has been marked as a duplicate of this bug. ***

Comment 18

[Ninoschka Baca]

Trunk build 2003-05-22: WinMe, Mac 10.1.5
Verified Fixed. Images now display on POP folders, local folders (drafts and
templates).