1836036 - [US][www.samsung.com/us] The Address Doorhanger is not displayed upon address form submission

Status: REOPENED

(Toolkit :: Form Autofill, defect, P3)

Description

[Ina Popescu, Desktop QA]

Found in

• Nightly 115.0a1

Affected versions

• Nightly 115.0a1

Tested platforms

• Affected platforms: Windows

Preconditions

• Install the Firefox en-US build
• Set browser.search.region to US in about:config
• Flip following prefs in about:config:
  extensions.formautofill.addresses.capture.v2.enabled = true
  extensions.formautofill.addresses.supported = on
• Use US VPN to test

Steps to reproduce

1. Log into https://www.samsung.com/us/ , add an item to bag and navigate to checkout page
2. Fill in the Address Form and press the submit button

Expected result

• The address doorhanger is triggered upon address form submission.

Actual result

• The address doorhanger is not triggered upon address form submission.

Regression range

• Not a recent regression because the feature is disabled by default.

Additional notes

• Fathom Fox page: https://drive.google.com/file/d/1od8lkf7ZcZpB_Xhs4mol3oxCdepcjg9Q/view?usp=sharing

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:epopescu, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Dimi Lee [:dimi]]

Fixed by either Bug 1870718 or Bug 1863801

Comment 3

[Ina Popescu, Desktop QA]

Attachment: samsung.mp4

Unfortunately the issue persists in the latest Nightly 123.0a1 on Windows10 x64.
I've checked also with pref extensions.formautofill.addresses.capture.requiredFields left empty, but the address doorhanger is still not displayed. This might be due to the fact that City and State fields are autocompleted based on Zip Code filled in or that there is an error "The credit card information you have entered is invalid." on the checkout page.
Could you please have a look? Thanks

Comment 4

[Dimi Lee [:dimi]]

The website implements the state field with a "hidden" and "non-focusable" <select> and a visible <div> with multiple <li> to simulate the select-like field.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

:janikaneuberger, since you are the author of the regressor, bug 1847687, could you take a look?

For more information, please visit BugBot documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1847687

Comment 7

[Donal Meehan [:dmeehan]]

Setting versions as disabled based on the repro steps. Please correct if needed.

Comment 8

[Dimi Lee [:dimi]]

Should be fixed by 1880450

Comment 9

[Ina Popescu, Desktop QA]

Updating the title of the issue and its description because the initial test was done on https://www.samsung.com/us/ using CA VPN.
I've retested the address doorhanger on https://www.samsung.com/us/ using US VPN and https://www.samsung.com/ca_fr/ using CA VPN in both Nightly 115.0a1 and the latest Nightly 125.0a1 on Windows10 x64.
The address doorhanger is not displayed on https://www.samsung.com/us/(+US VPN) or https://www.samsung.com/ca_fr/(+CA VPN) in none of the two Nightly builds mentioned above.

Comment 10

[Johannes]

(In reply to Dimi Lee [ooo 29.03 - 07.04] from comment #4)

The website implements the state field with a "hidden" and "non-focusable" <select> and a visible <div> with multiple <li> to simulate the select-like field.

looks like its based on http://selectric.js.org/ The input field is not of type hidden, but hidden via css. It has a proper autocomplete value:

<input class="selectric-input" tabindex="0" autocomplete="address-level1" aria-labelledby="ae-formFieldLabelOptIn_9agaw6shvxa_0">

Comment 11

[Johannes]

we are actually capturing the address-level1:

  {
    "elementWeakRef": {},
    "identifier": "/",
    "fieldName": "address-level1",
    "reason": "autocomplete",
    "section": "",
    "addressType": "",
    "contactType": "",
    "credentialType": "",
    "part": null,
    "confidence": null
  }

but _onFormSubmit (and _onAddressSubmit) is never called. So it might be a problem of the form submission detection heuristics.

Comment 12

[Johannes]

it also does not work on https://shop.samsung.com/de btw, but due to different reasons: required fields are not sufficient, here address-level1 is missing. If one removes address-level1 from extensions.formautofill.addresses.capture.requiredFields, then it works.

Comment 13

[Johannes]

Attachment: Invalid Credit Card Warning during Samsung Checkout

Comment 14

[Johannes]

I wonder if the submit detection fails because this error pops up. We can see it also in the video. Ina, could you test this with a valid CC?

Comment 15

[Ina Popescu, Desktop QA]

Attachment: samsung.mp4

Unfortunately, I'm unable to test this scenario with a valid credit card. However, I retested the issue using Samsung Pay as payment method in the latest Nightly 126.0a1 on Windows 10 x64.
The address doorhanger is still not displayed when the page is refreshed after filling in all the details, or pressing the "Continue to Samsung Pay" button. Please see the attachment.

Comment 16

[Johannes]

Thank you very much, Ina, I will debug further

Comment 17

[Johannes]

The problem is actually the form submission heuristics.

In addition to the standard HTML form submission, there are two other form submission scenarios that we can detect as of today:

• Page navigation (the location of the entire page or the iframe containing the form changes)
• Form removed after fetch event

In this, it is neither a standard HTML form submission, nore the html changes even after interaction with the server.

Chrome also does not display its address capture doorhanger here.

Comment 18

[Ina Popescu, Desktop QA]

Same issue can be observed on https://www.samsung.com/pl/in Nightly 132.0a1 on Windows10 x64. However it is displayed when setting the pref extensions.formautofill.addresses.capture.requiredFields = empty in about:config.